Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

glas: init at 0.2.2 #298321

Merged
merged 1 commit into from
Mar 27, 2024
Merged

glas: init at 0.2.2 #298321

merged 1 commit into from
Mar 27, 2024

Conversation

bhankas
Copy link
Contributor

@bhankas bhankas commented Mar 23, 2024

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/1016/116

Copy link
Contributor

@MaxwellDupre MaxwellDupre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I dont see any obvious issues.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/1554

pkgs/by-name/gl/glas/package.nix Show resolved Hide resolved
pkgs/by-name/gl/glas/package.nix Outdated Show resolved Hide resolved
@iFreilicht
Copy link
Contributor

Builds fine on aarch64-darwin, output of nix-shell -p nixpkgs-review --run "nixpkgs-review pr 298321" looks good 👍

v0.2.2 was released two days ago, maybe update this now so the package isn't immediately outdated.

@bhankas bhankas changed the title glas: init at 0.2.1 glas: init at 0.2.2 Mar 27, 2024
@bhankas
Copy link
Contributor Author

bhankas commented Mar 27, 2024

Builds fine on aarch64-darwin, output of nix-shell -p nixpkgs-review --run "nixpkgs-review pr 298321" looks good 👍

v0.2.2 was released two days ago, maybe update this now so the package isn't immediately outdated.

Done!

@bhankas bhankas self-assigned this Mar 27, 2024
Copy link
Contributor

@iFreilicht iFreilicht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from my side as well!

@SuperSandro2000 SuperSandro2000 merged commit 074042d into NixOS:master Mar 27, 2024
24 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants