-
-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python311Packages.scipy: remove references to dev outputs #298685
Conversation
I think changes look good, but I don't understand them fully. In anycase, it should target staging.
…On 24 March 2024 19:49:09 GMT+02:00, "ofborg[bot]" ***@***.***> wrote:
@ofborg[bot] requested your review on: NixOS/nixpkgs#298685 python311Packages.scipy: remove references to dev outputs.
--
Reply to this email directly or view it on GitHub:
#298685 (comment)
You are receiving this because your review was requested.
Message ID: ***@***.***>
|
nuke-reference replaces the paths in the file referencing the build time dependencies with fake nix store paths only containing eeeeees. |
2ef137f
to
92aca9c
Compare
What is the difference between that and `remove-references-to`?
…On 24 March 2024 23:06:56 GMT+02:00, Sandro ***@***.***> wrote:
nuke-reference replaces the paths in the file referencing the build time dependencies with fake nix store paths only containing eeeeees.
--
Reply to this email directly or view it on GitHub:
#298685 (comment)
You are receiving this because your review was requested.
Message ID: ***@***.***>
|
OK I found my answer at: https://discourse.nixos.org/t/whats-the-difference-between-removereferencesto-and-nukereferences/35075 Also @SuperSandro2000 , could you show please which references were there before and after this change? I'd like to spare my self building this package on the |
nuke-references just removes all, while remove-references-to takes a specific list.
I think this is somehow related to the build system, numpy has the same file with similar content. The pyc file is just the compiled bytecode from python. We compile with -OO but the test run I think with only -O and our hook is not cleaning that up somehow. --- result-before/lib/python3.11/site-packages/scipy/__config__.py
+++ result-after/lib/python3.11/site-packages/scipy/__config__.py
@@ -55,15 +55,15 @@
"version": "13.2.0",
"commands": "gfortran",
"args": "",
"linker args": "",
},
"pythran": {
"version": "0.15.0",
- "include directory": r"/nix/store/5ia6f6sfzqg4831sqa548hxqz3x7ryc4-python3.11-pythran-0.15.0/lib/python3.11/site-packages/pythran"
+ "include directory": r"/nix/store/eeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee-python3.11-pythran-0.15.0/lib/python3.11/site-packages/pythran"
},
},
"Machine Information": {
"host": {
"cpu": "x86_64",
"family": "x86_64",
"endian": "little",
@@ -82,35 +82,35 @@
"name": "blas",
"found": bool("True".lower().replace('false', '')),
"version": "3",
"detection method": "pkgconfig",
"include directory": r"unknown",
"lib directory": r"unknown",
"openblas configuration": "unknown",
- "pc file directory": r"/nix/store/217gkl46213hrszin5mx2ga6aifmp96h-blas-3-dev/lib/pkgconfig",
+ "pc file directory": r"/nix/store/eeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee-blas-3-dev/lib/pkgconfig",
},
"lapack": {
"name": "lapack",
"found": bool("True".lower().replace('false', '')),
"version": "3",
"detection method": "pkgconfig",
"include directory": r"unknown",
"lib directory": r"unknown",
"openblas configuration": "unknown",
- "pc file directory": r"/nix/store/jg131f5mbra6aps97j0if05m9ml2008l-lapack-3-dev/lib/pkgconfig",
+ "pc file directory": r"/nix/store/eeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee-lapack-3-dev/lib/pkgconfig",
},
"pybind11": {
"name": "pybind11",
"version": "2.11.1",
"detection method": "pkgconfig",
- "include directory": r"/nix/store/qiwimi4yv292pny7fgdqi4mrxr0ylxb0-python3.11-pybind11-2.11.1/include",
+ "include directory": r"/nix/store/eeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee-python3.11-pybind11-2.11.1/include",
},
},
"Python Information": {
- "path": r"/nix/store/7wz6hm9i8wljz0hgwz1wqmn2zlbgavrq-python3-3.11.8/bin/python3.11",
+ "path": r"/nix/store/eeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee-python3-3.11.8/bin/python3.11",
"version": "3.11",
},
}
)
def _check_pyyaml():
|
Great thanks for the explanation! It's good to have this documented at least here. |
Description of changes
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.