-
-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dlang dstep: init at 1.0.4 #299797
dlang dstep: init at 1.0.4 #299797
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It deserves a full rewrite.
yes building from source would be more preferable. What is this linker_flags.txt you are referring to? I found no mention of this file in the github repo of dstep. I only see in the readme that you need to run configure to the path where libclang lives:
so
probably works. |
@AndersonTorres thanks for the feedback. I've updated it know. Quite new with building packages and saw it used in some other place though i probably misunderstood :-) |
Will give it a try tommorow |
technically it should be |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reword the commits
- "maintainers: add imrying"
- "dstep: init at 1.0.0"
I guess if it should not be packaged as a binary it will make sense to wait for this PR to be merged in order to have consistency as to how dub packages are built. Even though it does not have any dub dependencies |
Will update to use buildDubPackage therefore marking as draft until finished |
bd91c50
to
dcafbb9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you for converting to a source build!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested converting a C header. Thanks!
Description of changes
From github: DStep is a tool for automatically generating D bindings for C and Objective-C libraries. This is implemented by processing C or Objective-C header files and output D modules. DStep uses the Clang compiler as a library (libclang) to process the header files.
Things done
I packaged the binary from releases since they are statically linked, and the configuration flow does not allow for easily updating to nix-style due to linker flags have to being set. If possible I think we could generate the
linker_flags.txt
manually and use this. Let me know if it is okay to package the binaries directly :-).nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.