nixos/monado: refactor #299841
Closed
nixos/monado: refactor #299841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Scrumplex
requested changes
Mar 29, 2024
PassiveLemon
force-pushed
the
monado
branch
2 times, most recently
from
c9010b4
to
ff4647e
Compare
Pandapip1
suggested changes
Jul 3, 2024
| example = true; | ||
| }; | ||
| runtime in a writable XDG_CONFIG_DIRS location like `~/.config` | ||
| '' // { default = true; }; |
There was a problem hiding this comment.
Should this really be true by default?
| environment.systemPackages = [ cfg.package ]; | ||
| environment.pathsToLink = [ "/share/openxr" ]; | ||
| services = { | ||
| monado.environment = { |
There was a problem hiding this comment.
Might it make sense to make services.monado.environment part of options so that XRT_COMPOSITOR_LOG, XRT_PRINT_OPTIONS, and IPC_EXIT_ON_DISCONNECT can be documented?
|
Forgot I even had this open. I don't even use Monado so I'm just going to close this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Adds a setting to configure environment variables for Monado. 3 Variables will be set by default if they are not defined.
We also set the defaultRuntime option to true because realistically, if someone is using this module, they are going to be using it as their runtime so we can save a configuration line.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.