-
-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nixos/monado: refactor #299841
nixos/monado: refactor #299841
Conversation
c9010b4
to
ff4647e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please reformat with nixfmt-rfc-style
example = true; | ||
}; | ||
runtime in a writable XDG_CONFIG_DIRS location like `~/.config` | ||
'' // { default = true; }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this really be true
by default?
environment.systemPackages = [ cfg.package ]; | ||
environment.pathsToLink = [ "/share/openxr" ]; | ||
services = { | ||
monado.environment = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might it make sense to make services.monado.environment
part of options
so that XRT_COMPOSITOR_LOG
, XRT_PRINT_OPTIONS
, and IPC_EXIT_ON_DISCONNECT
can be documented?
Forgot I even had this open. I don't even use Monado so I'm just going to close this. |
Description of changes
Adds a setting to configure environment variables for Monado. 3 Variables will be set by default if they are not defined.
We also set the defaultRuntime option to true because realistically, if someone is using this module, they are going to be using it as their runtime so we can save a configuration line.
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.