-
-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cudaPackages.autoAddX: Deprecate #300321
Merged
ConnorBaker
merged 2 commits into
NixOS:master
from
jonringer:deprecate-cuda-autoAddDriver
Apr 10, 2024
Merged
cudaPackages.autoAddX: Deprecate #300321
ConnorBaker
merged 2 commits into
NixOS:master
from
jonringer:deprecate-cuda-autoAddDriver
Apr 10, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonringer
force-pushed
the
deprecate-cuda-autoAddDriver
branch
from
April 8, 2024 21:40
5e8a430
to
c40c1b2
Compare
jonringer
force-pushed
the
deprecate-cuda-autoAddDriver
branch
5 times, most recently
from
April 8, 2024 22:59
1c5035d
to
a720219
Compare
SomeoneSerge
reviewed
Apr 9, 2024
jonringer
force-pushed
the
deprecate-cuda-autoAddDriver
branch
3 times, most recently
from
April 10, 2024 01:40
8edba88
to
b5b316a
Compare
ConnorBaker
approved these changes
Apr 10, 2024
@jonringer looks good to me -- feel free to merge after |
jonringer
force-pushed
the
deprecate-cuda-autoAddDriver
branch
from
April 10, 2024 15:28
b5b316a
to
bfbd578
Compare
The formatter is displeased now? |
jonringer
force-pushed
the
deprecate-cuda-autoAddDriver
branch
from
April 10, 2024 15:31
bfbd578
to
dadbcf9
Compare
Yea.... need to alter my vim setup to now run nixfmt on stuff |
SomeoneSerge
approved these changes
Apr 10, 2024
Merging since CI passed. Thank you @jonringer :) |
After 2.5 years, finally checked this off of my "weirdness budget" list |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Draft until the following have been merged:
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.