-
-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
coolercontrol.*: 1.1.1 -> 1.2.2 #300711
coolercontrol.*: 1.1.1 -> 1.2.2 #300711
Conversation
Am abit strapped for time right now, but will get to this on the weekend. |
I have added 2 commits (hope pushing to your branch was okay):
|
Thanks @OPNA2608 ! I'm build testing for a small patch, the webkit2gtk build is running so I'll wait until that's done and clean that up and push. (That build takes quite some time) And no prob commiting to the branch, appreciate the help. 👍🏼 |
So we don't need to add bash to the service's PATH
ae39481
to
29ef3d5
Compare
All good from my side now. No patches in the near future planned. |
@ofborg build coolercontrol.coolercontrol-ui-data coolercontrol.coolercontrold coolercontrol.coolercontrold.passthru.tests coolercontrol.coolercontrol-liqctld coolercontrol.coolercontrol-gui |
Builds on ofborg, and works locally. I don't use Nvidia hardware on Linux, so I can only test the option insofar that:
LGTM. |
Description of changes
Update for CoolerControl 1.1.1 -> 1.2.2
https://gitlab.com/coolercontrol/coolercontrol/-/releases/1.2.0
https://gitlab.com/coolercontrol/coolercontrol/-/releases/1.2.1
https://gitlab.com/coolercontrol/coolercontrol/-/releases/1.2.2
No breaking changes.
A nice-to-have would be to include any package changes to allow the
coolercontrold
systemd daemon access tosh
and nvidia binaries if present.https://gitlab.com/coolercontrol/coolercontrol/-/issues/263
(help needed)
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.