Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linux: set various common hardening config #300815

Merged
merged 9 commits into from
Jun 12, 2024

Conversation

amarshall
Copy link
Member

@amarshall amarshall commented Apr 2, 2024

Description of changes

See commits.

Things done

I have been running with these changes on several x86_64 machines with different platforms since ~2 weeks prior to opening this PR.

Tested building all configs; plus (based off nixos-unstable) tests for default, oldest, and newest Kernels.

echo '{ allowAliases = false; }' > config.nix
NIXPKGS_CONFIG="$(pwd)/config.nix" nix-build -A nixosTests.kernel-generic.passthru.configfiles

nix-build -A linux.passthru.tests -A linux_4_19.passthru.tests -A linux_6_8.passthru.tests
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@amarshall
Copy link
Member Author

amarshall commented Jun 11, 2024

Rebased against latest staging, retested (against nixos-unstable to avoid big builds) all configs build and linux_6_9.passthru.tests.

These are set in common-config.
The comments from the blocks above apply only to a single line, but that
is not necessarily clear. Add blank lines to more clearly narrow the
scope of them.
Copy link
Contributor

@K900 K900 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall diff LGTM, but we should merge this with the next kernel update cycle.

@K900 K900 merged commit 93fb179 into NixOS:staging Jun 12, 2024
24 of 25 checks passed
@K900
Copy link
Contributor

K900 commented Jun 12, 2024

That could have gone into master, but whatever.

@amarshall amarshall deleted the linux-common-hardening branch June 13, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants