-
-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mricron: init at 1.0.20190902 #301030
mricron: init at 1.0.20190902 #301030
Conversation
b878428
to
577b7c6
Compare
cb1c08e
to
2555431
Compare
mricron is a mri data imaging application. The newest updates seem to be in mricrogl instead of mricron, but this does not require opengl, wich can be preferable. |
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/4275 |
Added you as coauthor. Could look into the autopatchelf vs autopatchelfHook, latter builds at least. |
I've noticed that all files from |
Should be fine with just 444. Ended up just removing it as is not really needed. |
6d018c4
to
96a053f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks pretty good. I'd just suggest adding line breaks between logical units (as displayed in code suggestions) and I think it is good to merge then
Co-authored-by: Florian Brandes <florian.brandes@posteo.de>
@ofborg eval |
This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch). Result of 1 package built:
|
I'll merge once ofborg has run 👍 |
Description of changes
I tried to package mricron
can be found on https://github.com/neurolabusc/MRIcron or https://www.nitrc.org/projects/mricron
(github was used as upstream)
description from website:
MRIcron is a cross-platform NIfTI format image viewer. It can load multiple layers of images, generate volume renderings and draw volumes of interest. It also provides dcm2nii for converting DICOM images to NIfTI format and NPM for statistics. MRIcron is a mature and useful tool, however you may want to consider the more recent MRIcroGL as an alternative.
Currently only mricron is packaged because i found the package dcm2niix and i dont think it would be nessesary to add the bundeled one.
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.