Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mricron: init at 1.0.20190902 #301030

Merged
merged 1 commit into from
Jul 24, 2024
Merged

mricron: init at 1.0.20190902 #301030

merged 1 commit into from
Jul 24, 2024

Conversation

adrlau
Copy link
Contributor

@adrlau adrlau commented Apr 2, 2024

Description of changes

I tried to package mricron
can be found on https://github.com/neurolabusc/MRIcron or https://www.nitrc.org/projects/mricron
(github was used as upstream)

description from website:

MRIcron is a cross-platform NIfTI format image viewer. It can load multiple layers of images, generate volume renderings and draw volumes of interest. It also provides dcm2nii for converting DICOM images to NIfTI format and NPM for statistics. MRIcron is a mature and useful tool, however you may want to consider the more recent MRIcroGL as an alternative.

Currently only mricron is packaged because i found the package dcm2niix and i dont think it would be nessesary to add the bundeled one.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@adrlau
Copy link
Contributor Author

adrlau commented Apr 17, 2024

mricron is a mri data imaging application. The newest updates seem to be in mricrogl instead of mricron, but this does not require opengl, wich can be preferable.

@adrlau adrlau changed the title mricrm: init at 1.2.20211006 mricron: init at 1.2.20211006 May 27, 2024
@adrlau adrlau changed the title mricron: init at 1.2.20211006 mricron: init at 1.0.20190902 May 27, 2024
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/4275

pkgs/by-name/mr/mricron/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/mr/mricron/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/mr/mricron/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/mr/mricron/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/mr/mricron/package.nix Outdated Show resolved Hide resolved
@adrlau
Copy link
Contributor Author

adrlau commented Jul 18, 2024

Added you as coauthor.

Could look into the autopatchelf vs autopatchelfHook, latter builds at least.

@gador
Copy link
Member

gador commented Jul 19, 2024

I've noticed that all files from ./Resources/* have executable permission. Is this necessary for mricron to work? Or can we install them as 444 ?

@adrlau
Copy link
Contributor Author

adrlau commented Jul 19, 2024

I've noticed that all files from ./Resources/* have executable permission. Is this necessary for mricron to work? Or can we install them as 444 ?

Should be fine with just 444. Ended up just removing it as is not really needed.

pkgs/by-name/mr/mricron/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/mr/mricron/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/mr/mricron/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/mr/mricron/package.nix Show resolved Hide resolved
@adrlau adrlau force-pushed the init-mricron branch 2 times, most recently from 6d018c4 to 96a053f Compare July 22, 2024 17:43
Copy link
Member

@gador gador left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks pretty good. I'd just suggest adding line breaks between logical units (as displayed in code suggestions) and I think it is good to merge then

pkgs/by-name/mr/mricron/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/mr/mricron/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/mr/mricron/package.nix Outdated Show resolved Hide resolved
Co-authored-by: Florian Brandes <florian.brandes@posteo.de>
@gador
Copy link
Member

gador commented Jul 23, 2024

@ofborg eval

@gador
Copy link
Member

gador commented Jul 23, 2024

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).

Result of nixpkgs-review pr 301030 run on x86_64-linux 1

1 package built:
  • mricron

@gador
Copy link
Member

gador commented Jul 23, 2024

I'll merge once ofborg has run 👍

@gador gador merged commit bca987b into NixOS:master Jul 24, 2024
24 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants