Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

luneta: init at 0.7.4 #301615

Merged
merged 1 commit into from
Apr 21, 2024
Merged

luneta: init at 0.7.4 #301615

merged 1 commit into from
Apr 21, 2024

Conversation

TomaSajt
Copy link
Contributor

@TomaSajt TomaSajt commented Apr 4, 2024

Description of changes

This PR adds 1 package: luneta

Homepage: https://github.com/fbeline/luneta

Now that #299618 is merged, I was looking around for other D programs to package and luneta seemed cool.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@lolbinarycat
Copy link
Contributor

I tried to build this, but unfortunately code.dlang.org is down right now. codemirror.dlang.org should be added to the mirrors list (fetchurl/mirrors.nix), which i'm going to open a PR for right now.

Copy link
Contributor

@lolbinarycat lolbinarycat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code.dlang.org is back online, built and ran successfully on x86_64-linux, also derivation formatting looks fine enough.

@imrying
Copy link
Contributor

imrying commented Apr 9, 2024

Works for me.
Result of nixpkgs-review pr 301615 run on x86_64-linux 1

1 package built:
  • luneta

Copy link
Member

@pbsds pbsds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result of nixpkgs-review pr 301615 run on x86_64-linux 1

1 package built:
  • luneta

tested $ fd . nixpkgs/ | results/luneta/bin/luneta, LGTM

@pbsds pbsds merged commit f081128 into NixOS:master Apr 21, 2024
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants