-
-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
keydb: init at 6.3.4 #301804
Merged
Merged
keydb: init at 6.3.4 #301804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conni2461
force-pushed
the
init/keydb
branch
2 times, most recently
from
April 5, 2024 11:42
0e780cb
to
7c2f4ed
Compare
Aleksanaa
reviewed
Apr 10, 2024
Conni2461
force-pushed
the
init/keydb
branch
2 times, most recently
from
April 10, 2024 19:42
630920c
to
b33839e
Compare
dasJ
requested changes
Apr 11, 2024
@@ -391,7 +391,8 @@ in { | |||
RestrictAddressFamilies = [ "AF_INET" "AF_INET6" "AF_UNIX" ]; | |||
RestrictNamespaces = true; | |||
LockPersonality = true; | |||
MemoryDenyWriteExecute = true; | |||
# we need to disable MemoryDenyWriteExecute for keydb | |||
MemoryDenyWriteExecute = cfg.package != pkgs.keydb; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd rather go with comparing pname
rather than the entire package
dasJ
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
very similar to the already existing redis package
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.