nixos/sddm: allow disabling the rest of X11 #303114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why add a new option instead of simply using |
|
Valid. |
pSub
approved these changes
Apr 10, 2024
| @@ -66,7 +66,7 @@ let | |||
| HideShells = "/run/current-system/sw/bin/nologin"; | |||
| }; | |||
|
|
|||
| X11 = { | |||
| X11 = optionalAttrs config.services.xserver.enable { | |||
There was a problem hiding this comment.
Suggested change
| X11 = optionalAttrs config.services.xserver.enable { | |
| X11 = optionalAttrs xcfg.enable { |
I had this change in my testing branch but probably forgot to carry it over to the PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This should allow getting rid of all X dependencies on Wayland-only systems.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.