nixos/display-managers: add renamed option missed in #291913 #303186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
philiptaron
approved these changes
Apr 10, 2024
Shawn8901
approved these changes
Apr 10, 2024
|
You'll want to rebase on the latest |
philiptaron
approved these changes
Apr 10, 2024
There was a problem hiding this comment.
Here's the list of options under services.xserver.displayManager on release-23.11:
release-23.11-services.xserver.displayManager.txt
Here's the list on master (prior to this PR): master-services.xserver.displayManager.txt
Diff:
defaultSession
desktopManagerHandlesLidAndPower
extraSessionFilesPackages
gdm
-hiddenUsers
importedVariables
job
lightdm
logToJournal
sddm
session
sessionCommands
-sessionData
-sessionPackages
setupCommands
slim
startx
sxThis suggests that hiddenUsers is also needs this same treatment.
|
I meant to request changes there, dang it. |
fufexan
added a commit
to fufexan/dotfiles
that referenced
this pull request
Apr 11, 2024
hosts/io: add workaround for NixOS/nixpkgs#303186 hosts/io/powersave: disable i2c and pci powersave that might *still* cause problems for NVME
SuperSandro2000
force-pushed
the
sddm-xserver-followup
branch
from
a3f6a7e
to
c6a0404
Compare
|
good catch @philiptaron 👍🏼 Ammended that one |
philiptaron
approved these changes
Apr 12, 2024
Icey-Glitch
added a commit
to Icey-Glitch/NixDots
that referenced
this pull request
Apr 18, 2024
Signed-off-by: Icey-Glitch <Icey-Glitch@riseup.net>
fufexan
pushed a commit
to fufexan/dotfiles
that referenced
this pull request
Apr 18, 2024
Signed-off-by: Icey-Glitch <Icey-Glitch@riseup.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.