-
-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nixos/display-managers: add renamed option missed in #291913 #303186
nixos/display-managers: add renamed option missed in #291913 #303186
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love to see it. Thanks for the quick turnaround.
I don't believe the ofBorg eval failure is related.
You'll want to rebase on the latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here's the list of options under services.xserver.displayManager
on release-23.11
:
release-23.11-services.xserver.displayManager.txt
Here's the list on master (prior to this PR): master-services.xserver.displayManager.txt
Diff:
defaultSession
desktopManagerHandlesLidAndPower
extraSessionFilesPackages
gdm
-hiddenUsers
importedVariables
job
lightdm
logToJournal
sddm
session
sessionCommands
-sessionData
-sessionPackages
setupCommands
slim
startx
sx
This suggests that hiddenUsers
is also needs this same treatment.
I meant to request changes there, dang it. |
hosts/io: add workaround for NixOS/nixpkgs#303186 hosts/io/powersave: disable i2c and pci powersave that might *still* cause problems for NVME
a3f6a7e
to
c6a0404
Compare
good catch @philiptaron 👍🏼 Ammended that one |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅
Someday, I'll add detection like this to nixpkgs-check-by-name.
Signed-off-by: Icey-Glitch <Icey-Glitch@riseup.net>
Signed-off-by: Icey-Glitch <Icey-Glitch@riseup.net>
Description of changes
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.