Aria2 module settings

[timhae]

Description of changes

aria2 module settings, added nixos test and myself as maintainer

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[timhae]

Result of nixpkgs-review pr 303429 run on x86_64-linux 1

1 package blacklisted:

• nixos-install-tools

[ambroisie]

I would split the addition of the test from the new settings option.

Could you also either not change the formatting, or split it into a different commit?

Otherwise thank you for adding a test to the module! This makes me much more confident for refactoring it now :-)

[timhae]

Thanks for your comments, I have tried to address all of them. Please let me know what you think.

[jys1670]

I am getting error: The option 'services.aria2.settings' is used but not defined. on the latest nixos-unstable.
Was this meant to happen? From a brief look, it seems that services.aria2.settings should be defined with some default values.
@timhae

[timhae]

@jys1670 can you please post your services.aria2 settings in your nixconfig?

[jys1670]

@jys1670 can you please post your services.aria2 settings in your nixconfig?

Yeah, sure:

  services.aria2 = {
    enable = true;
    rpcSecretFile = "${pkgs.writeText "aria" "aria2rpc\n"}";
  };

It's working fine if I revert this PR. Should something else be defined for default settings on latest nixos-unstable?
--show-trace (just in case)

[timhae]

Sorry for breaking your config, can you change that to:

  services.aria2 = {
    enable = true;
    rpcSecretFile = "${pkgs.writeText "aria" "aria2rpc\n"}";
    settings = { };
  };

[jys1670]

Sorry for breaking your config, can you change that to:

  services.aria2 = {
    enable = true;
    rpcSecretFile = "${pkgs.writeText "aria" "aria2rpc\n"}";
    settings = { };
  };

Thanks! This fixed the issue for me.

[timhae]

created PR #320035