-
-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Aria2 module settings #303429
Aria2 module settings #303429
Conversation
Result of 1 package blacklisted:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would split the addition of the test from the new settings
option.
Could you also either not change the formatting, or split it into a different commit?
Otherwise thank you for adding a test to the module! This makes me much more confident for refactoring it now :-)
Thanks for your comments, I have tried to address all of them. Please let me know what you think. |
554dfbb
to
c19d2cd
Compare
I also took the liberty to add myself as module maintainer
I am getting |
@jys1670 can you please post your |
Yeah, sure: services.aria2 = {
enable = true;
rpcSecretFile = "${pkgs.writeText "aria" "aria2rpc\n"}";
}; It's working fine if I revert this PR. Should something else be defined for default settings on latest nixos-unstable? |
Sorry for breaking your config, can you change that to:
|
Thanks! This fixed the issue for me. |
created PR #320035 |
Description of changes
aria2 module settings, added nixos test and myself as maintainer
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.