lomiri.* Fix lack of output fixup in pkg-config files, update pkg-config calls with new CMake option #303595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… pkg-config call with new CMake option
…g file, update pkg-config call with new CMake option
|
Result of 23 packages built:
Also checked on top of #292872, no issues there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
I noticed that some pkg-config files didn't get patched with the correct outputs (
$devforincludedir). It didn't cause any issues so far, but let's fix them anyway. In the case ofu1db-qt, the pkg-config file actually has a completely broken includedir.Also, since we now have a newer CMake, we can start adjusting the substitutions on pkg-config calls to just add a
prefixsubstitution, instead of replacing them entirely with path hardcodings.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.