Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fgqcanvas: Init at 0.1 #303714

Merged
merged 1 commit into from
Apr 23, 2024
Merged

fgqcanvas: Init at 0.1 #303714

merged 1 commit into from
Apr 23, 2024

Conversation

merspieler
Copy link
Contributor

Description of changes

A Qt-based remote canvas application for FlightGear

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

pkgs/by-name/fg/fgqcanvas/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/fg/fgqcanvas/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/fg/fgqcanvas/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/fg/fgqcanvas/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/fg/fgqcanvas/package.nix Show resolved Hide resolved
pkgs/by-name/fg/fgqcanvas/package.nix Show resolved Hide resolved
@merspieler merspieler force-pushed the fgqcanvas branch 2 times, most recently from 2562e7f to 1ac3ea1 Compare April 16, 2024 21:51
@auroraanna
Copy link
Contributor

commit name is still for version 0.1

Copy link
Member

@lilyinstarlight lilyinstarlight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing configure hooks and there is the above-mentioned version nit, but otherwise this looks good

pkgs/by-name/fg/fgqcanvas/package.nix Show resolved Hide resolved
pkgs/by-name/fg/fgqcanvas/package.nix Show resolved Hide resolved
Signed-off-by: fly <merspieler@alwaysdata.com>
Copy link
Member

@lilyinstarlight lilyinstarlight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me now! I'll wait on ofborg eval checks to finish but otherwise this seems merge-ready

@lilyinstarlight lilyinstarlight merged commit 5909e4b into NixOS:master Apr 23, 2024
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants