Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.nptyping: Fix test bug #303716

Merged
merged 1 commit into from
Apr 17, 2024
Merged

Conversation

Pandapip1
Copy link
Contributor

@Pandapip1 Pandapip1 commented Apr 12, 2024

Description of changes

One of the tests fails for some unknown reason. This PR disables that test.

Fixes #303715

Blocking #303718

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@Pandapip1
Copy link
Contributor Author

@kirillrdy a more descriptive comment has been provided.

@kirillrdy
Copy link
Member

@Pandapip1 please update commit message to match contribution guide lines ( and PR title )

https://github.com/NixOS/nixpkgs/blob/master/pkgs/README.md#commit-conventions

attribute name here is python311Packages.nptyping

@Pandapip1 Pandapip1 changed the title Fix nptyping test bug nptyping: Fix test bug Apr 15, 2024
@Pandapip1
Copy link
Contributor Author

Done!

@kirillrdy
Copy link
Member

correct attribute name is python311Packages.nptyping or python3Packages.nptyping

@Pandapip1 Pandapip1 changed the title nptyping: Fix test bug python3Packages.nptyping: Fix test bug Apr 16, 2024
@Pandapip1
Copy link
Contributor Author

Sorry, misunderstood what you meant by 'attribute'. Is this what you're looking for?

@kirillrdy
Copy link
Member

yes, attribute, the reason its enforced in https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md

its because pattern in commit message is what ofborg uses to know what to build.

python is a bit special python3Packages.nptyping is correct attribute
but also so is python311Packages.nptyping ( which is currently default python3 ) I have notificed that ofborg doesn't trigger build jobs for python3Packages, so kicking it off manually

@GrahamcOfBorg build python3Packages.nptyping

@kirillrdy kirillrdy merged commit b68f30f into NixOS:master Apr 17, 2024
27 checks passed
@Pandapip1 Pandapip1 deleted the fix-nptyping branch April 18, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build failure: python311Packages.nptyping
3 participants