-
-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python3Packages.nptyping: Fix test bug #303716
Conversation
@kirillrdy a more descriptive comment has been provided. |
@Pandapip1 please update commit message to match contribution guide lines ( and PR title ) https://github.com/NixOS/nixpkgs/blob/master/pkgs/README.md#commit-conventions attribute name here is |
Done! |
correct attribute name is |
Sorry, misunderstood what you meant by 'attribute'. Is this what you're looking for? |
yes, attribute, the reason its enforced in https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md its because pattern in commit message is what ofborg uses to know what to build. python is a bit special @GrahamcOfBorg build python3Packages.nptyping |
Description of changes
One of the tests fails for some unknown reason. This PR disables that test.
Fixes #303715
Blocking #303718
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.