inkscape: fix path patch #303748
Merged
inkscape: fix path patch #303748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix a bug introduced in 0db4b99 by missing the change from `path` to `absolute` for the `location` argument
jtojnar
reviewed
Apr 13, 2024
jtojnar
approved these changes
Apr 14, 2024
jtojnar
reviewed
Apr 14, 2024
| { inkscape, runCommand, writeTextFile }: | ||
|
|
||
| let | ||
| svg_file = writeTextFile { |
There was a problem hiding this comment.
Maybe we could move this SVG into a separate file or use an existing svg file like in
There was a problem hiding this comment.
hello @jtojnar ,
I tried to reduce the svg file to a minimum, but would keep external deps to a minimum.
So our test gets not broken by a change in another package.
If you think otherwise I will change to the external file.
to prevent future regressen add a smal test, to check if ps2pdf plugin is working by createing a .ps / .eps file and converting it back to svg
|
Result of 2 packages marked as broken and skipped:
52 packages built:
|
|
Successfully created backport PR for |
1 task
|
Sorry I forgot about this. Thanks again. |
|
no problem, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Not be able to open
*.psor*.epsfiles with inkscapeReproduce:
create postscript file:
nix run -- nixpkgs#barcode -u mm -g 30x10 -o /tmp/barcode.ps -e ean13 -b 5421357512346try to open results in an error:
Not sure if this patch should be back-ported as currently you are not be able to open
*.psor*.epsfiles with inkscape.Description of changes
Fix a bug introduced in 0db4b99
by missing the change from
location="path"tolocation="absolute"Add unit test for auto test this function in the future.
Things done
I tested this patch only on gnu/Linux 23.11, I don't know how it works on
darwin.nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Maintainer:
@jtojnar
Add a 👍 reaction to pull requests you find important.