-
-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
inkscape: fix path patch #303748
inkscape: fix path patch #303748
Conversation
fix a bug introduced in 0db4b99 by missing the change from `path` to `absolute` for the `location` argument
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch. Thanks for including a test as well.
{ inkscape, runCommand, writeTextFile }: | ||
|
||
let | ||
svg_file = writeTextFile { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we could move this SVG into a separate file or use an existing svg file like in
${finalAttrs.finalPackage}/libexec/xdg-desktop-portal-validate-icon --sandbox 512 512 ${../../../applications/audio/zynaddsubfx/ZynLogo.svg} > "$out" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hello @jtojnar ,
I tried to reduce the svg file to a minimum, but would keep external deps to a minimum.
So our test gets not broken by a change in another package.
If you think otherwise I will change to the external file.
to prevent future regressen add a smal test, to check if ps2pdf plugin is working by createing a .ps / .eps file and converting it back to svg
Result of 2 packages marked as broken and skipped:
52 packages built:
|
Successfully created backport PR for |
Sorry I forgot about this. Thanks again. |
no problem, |
Bug
Not be able to open
*.ps
or*.eps
files with inkscapeReproduce:
create postscript file:
nix run -- nixpkgs#barcode -u mm -g 30x10 -o /tmp/barcode.ps -e ean13 -b 5421357512346
try to open results in an error:
Not sure if this patch should be back-ported as currently you are not be able to open
*.ps
or*.eps
files with inkscape.Description of changes
Fix a bug introduced in 0db4b99
by missing the change from
location="path"
tolocation="absolute"
Add unit test for auto test this function in the future.
Things done
I tested this patch only on gnu/Linux 23.11, I don't know how it works on
darwin
.nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Maintainer:
@jtojnar
Add a 👍 reaction to pull requests you find important.