Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

less: apply patch for security issue when opening files with \n in paths #303825

Merged
merged 1 commit into from
Apr 15, 2024

Conversation

LeSuisse
Copy link
Contributor

Description of changes

https://www.openwall.com/lists/oss-security/2024/04/12/5

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@LeSuisse
Copy link
Contributor Author

Less than 500 rebuilds? I thought it was bigger than that, moving back to master.

@LeSuisse LeSuisse changed the base branch from staging to master April 13, 2024 13:34
@fpletz fpletz merged commit c10fcc9 into NixOS:master Apr 15, 2024
32 checks passed
Copy link
Contributor

@LeSuisse LeSuisse deleted the less-sec-issue-newline-paths branch April 15, 2024 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants