Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/greenclip: restart daemon if it exits #303859

Merged
merged 1 commit into from
Apr 21, 2024

Conversation

presto8
Copy link
Contributor

@presto8 presto8 commented Apr 13, 2024

The Linux out-of-memory killer sometimes kills greenclip, as seen in the system journal:

greenclip.service: A process of this unit has been killed by the OOM killer.

This changeset adjusts the OOM score to reduce the likelihood that the greenclip process will be killed. Additionally, the systemd restart policy is set to "always" for greenclip service if it does get killed.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Copy link
Contributor

@tomfitzhenry tomfitzhenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@presto8 presto8 changed the title nixos/greenclip: protect against Linux OOM killer nixos/greenclip: restart process if it exits Apr 21, 2024
@presto8 presto8 marked this pull request as draft April 21, 2024 13:33
@presto8 presto8 changed the title nixos/greenclip: restart process if it exits nixos/greenclip: restart daemon if it exits Apr 21, 2024
@presto8 presto8 marked this pull request as ready for review April 21, 2024 13:37
@tomfitzhenry tomfitzhenry merged commit b877905 into NixOS:master Apr 21, 2024
9 of 10 checks passed
@presto8 presto8 deleted the greenclip-oom branch April 21, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants