glibc: allow (cross)-build on case-insensitive fs #303868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...such as APFS. The problem here is that a change inside the 2.39 patchset creates a file `ADVISORIES` and also contains a directory `advisories/` and both are considered the same file on APFS. Reproducible with `nix-build -A pkgsCross.gnu64.stdenv.cc` on a `aarch64-darwin` host. Hence, excluding the file from the patchset as it is non-functional anyways. Closes NixOS#303193
ofborg
bot
added
the
6.topic: cross-compilation
13 tasks
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
...such as APFS.
The problem here is that a change inside the 2.39 patchset creates a file
ADVISORIESand also contains a directoryadvisories/and both are considered the same file on APFS.Reproducible with
nix-build -A pkgsCross.gnu64.stdenv.ccon aaarch64-darwinhost.Hence, excluding the file from the patchset as it is non-functional anyways.
Closes #303193
cc @vcunat @quentinmit @ConnorBaker
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.