bats: 1.10.0 -> 1.11.0, resholve: fix related test breakage #303883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm preparing to update bats to 1.11.0, but a change it includes will require updating 3 of resholve's tests. Since a full resholve source bump would need to go through staging now, I'm just patching the tests in the separate test derivation.
Upcoming commit will add packages that use bats to passthru.tests, which is a little more clear when this is one attrset. Splitting this format-only change out for easier review.
It would have been ~easy for someone to update bats without noticing whether the update broke any packages that depend directly on the nixpkgs-packaged bats for their tests. (I'm phrasing this tediously because there are also some packages that vendor a copy of bats.) Hopefully this will make it easier to confirm future updates.
Also conditionally excludes pkill from resolution on macOS, since the procps package should contain pkill on other platforms.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Update bats to 1.11.0 (changelog entry for 1.11.0)
Work around some resholve tests broken by this update. This uses patches (for now) to avoid needing to go through staging.
Despite this, I'm deferring to the maintainer's opinion that this behavior shift doesn't rise to the level of a major/breaking change. After discussing with them, it sounds like I held it ~wrong and ended up depending on a ~quirky/buggy/misleading implementation detail that they needed to fix (for posterity, here's that discussion comment). They released a month ago (after a couple months in the release candidate stage) and I haven't seen issues/chatter indicating that this broke anyone else.
Add bats-tested packages to bats passthru.tests to reduce the likelihood we merge an update that'll break any of them (and do a little reformatting to aid this)
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Result of
nixpkgs-reviewrun on x86_64-darwin 14 packages built:
Add a 👍 reaction to pull requests you find important.