Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ckb-next: Fix udev rule #303919

Merged
merged 1 commit into from
Apr 14, 2024
Merged

ckb-next: Fix udev rule #303919

merged 1 commit into from
Apr 14, 2024

Conversation

traxys
Copy link
Contributor

@traxys traxys commented Apr 13, 2024

Description of changes

The current udev rule uses /usr/bin/env sed, which will fail the build if the package is added to services.udev.packages

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@traxys
Copy link
Contributor Author

traxys commented Apr 13, 2024

Result of nixpkgs-review pr 303919 run on x86_64-linux 1

1 package built:
  • ckb-next

@traxys traxys requested a review from Artturin April 13, 2024 23:11
The current udev rule uses `/usr/bin/env sed`, which will fail the build
if the package is added to `services.udev.packages`
@traxys traxys requested a review from Artturin April 14, 2024 09:39
@Artturin Artturin merged commit f6a5316 into NixOS:master Apr 14, 2024
26 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants