Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib: add lib.attrsets.mapAttrsRecursiveFunc #304026

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

deemp
Copy link
Contributor

@deemp deemp commented Apr 14, 2024

Description of changes

Added a new function lib.attrsets.mapAttrsRecursiveFunc that allows to apply a given function f to attrsets (not derivations) where f is applicable.

Initial problem

I use pkgs.writeShellApplication and create a number of scripts with similar runtimeInputs.
I have to write a pkgs.writeShellApplication, a name, and runtimeInputs for each script.

Initial solution

Create a custom library of functions and provide there a function that reduces boilerplate.
However, I don't want to use that library in my public projects because of a single function.

Things done

Note

no packages depend on the new function

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant