-
-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
commafeed: init at 4.3.3 #304257
commafeed: init at 4.3.3 #304257
Conversation
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/3822 |
gitProperties = writeText "git.properties" ( | ||
'' | ||
git.branch = none | ||
git.build.time = 1970-01-01T00:00:00+0000 | ||
git.build.version = ${common.version} | ||
git.commit.id = none | ||
git.commit.id.abbrev = none | ||
'' | ||
); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gitProperties = writeText "git.properties" ( | |
'' | |
git.branch = none | |
git.build.time = 1970-01-01T00:00:00+0000 | |
git.build.version = ${common.version} | |
git.commit.id = none | |
git.commit.id.abbrev = none | |
'' | |
); | |
gitProperties = writeText "git.properties" '' | |
git.branch = none | |
git.build.time = 1970-01-01T00:00:00+0000 | |
git.build.version = ${common.version} | |
git.commit.id = none | |
git.commit.id.abbrev = none | |
''; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
pkgs/by-name/co/commafeed/common.nix
Outdated
npmDepsHash = "sha256-fye7MPWXUeFCMgcnesspd1giGG/ZldiOv00fjtXZSb4="; | ||
|
||
mvnHash = "sha256-YnEDJf4GeyiXxOh8tZZTZdLOJrisG6lmShXU97ueGNE="; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would probably be easier and simpler if the hashes where at the specific package and the src is just inherited from the main package into the frontent.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I moved everything to package.nix
. After your comment I came to the conclusion that using separate files in this package doesn't give anything special. 1 file is simpler.
Additionally I formatted this PR using |
Description of changes
Adds CommaFeed package and module.
Link: https://github.com/Athou/commafeed
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.