-
-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python312Packages.pygame: unbreak #304471
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pbsds
force-pushed
the
fix-pygame-1713251863
branch
from
April 16, 2024 07:27
78b1b8c
to
3d79573
Compare
13 tasks
Not enough rebuilds to warrant staging. |
github-actions
bot
added
6.topic: kernel
8.has: documentation
6.topic: rust
6.topic: golang
6.topic: ruby
6.topic: vim
6.topic: stdenv
Standard environment
6.topic: nodejs
6.topic: lua
6.topic: systemd
6.topic: lib
The Nixpkgs function library
labels
Apr 18, 2024
pbsds
force-pushed
the
fix-pygame-1713251863
branch
from
April 18, 2024 19:38
3d79573
to
4613e20
Compare
github-actions
bot
removed
6.topic: kernel
8.has: documentation
6.topic: rust
6.topic: golang
6.topic: ruby
6.topic: vim
6.topic: stdenv
Standard environment
6.topic: nodejs
6.topic: lua
6.topic: systemd
6.topic: lib
The Nixpkgs function library
labels
Apr 18, 2024
the breakages strike me as random @ofborg build python312Packages.pygame python311Packages.pygame python312Packages.pygame.passthru python311Packages.pygame.passthru |
natsukium
reviewed
May 1, 2024
pbsds
force-pushed
the
fix-pygame-1713251863
branch
from
May 1, 2024 22:27
4613e20
to
e04c4fc
Compare
natsukium
approved these changes
May 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
fixes https://hydra.nixos.org/build/254894437
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.