Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quick-serve: init at 0.2.0 #304618

Closed
wants to merge 1 commit into from

Conversation

vinnymeller
Copy link
Contributor

@vinnymeller vinnymeller commented Apr 16, 2024

Description of changes

Adds the quick-serve application

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@vinnymeller
Copy link
Contributor Author

Result of nixpkgs-review run on x86_64-linux 1

1 package built:
  • quick-serve

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/3799

@vinnymeller
Copy link
Contributor Author

Redid after force push:

Result of nixpkgs-review run on x86_64-linux 1

1 package built:
  • quick-serve

pkgs/by-name/qu/quick-serve/package.nix Show resolved Hide resolved
pkgs/by-name/qu/quick-serve/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/qu/quick-serve/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/qu/quick-serve/package.nix Outdated Show resolved Hide resolved
];

meta = with lib; {
description = "A zero-config, multi-platform, multi-protocol standalone server for a prompt file serving";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
description = "A zero-config, multi-platform, multi-protocol standalone server for a prompt file serving";
description = "Zero-config, multi-platform, multi-protocol standalone server for a prompt file serving";

name = "Quick Serve";
exec = meta.mainProgram;
desktopName = "Quick Serve";
comment = meta.description;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
comment = meta.description;
comment = "Standalone server for a prompt file serving";

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants