-
-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clang-uml: init at 0.5.1 #304749
clang-uml: init at 0.5.1 #304749
Conversation
e62f348
to
041a909
Compare
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great aside from a few duped empty lines.
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/3870 |
@pogobanane is it ok for you that I use your work on clang-uml for nix packaging in this pr here (PR) |
We should merge this We already have that same wrapper here https://github.com/NixOS/nixpkgs/blob/0e2ddadf231ae164c333ac4d9e093c7ae21b970e/pkgs/development/tools/analysis/include-what-you-use/wrapper and here https://github.com/NixOS/nixpkgs/blob/master/pkgs/development/tools/clang-tools/wrapper. However for clang-uml-wrapped, we run the binary in a different way, so we can't copy paste them. We could move the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I tested a previous version of this patch with my own code.
Description of changes
Add the package clang-uml
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.