Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clang-uml: init at 0.5.1 #304749

Merged
merged 1 commit into from
Jun 5, 2024
Merged

clang-uml: init at 0.5.1 #304749

merged 1 commit into from
Jun 5, 2024

Conversation

hatch01
Copy link
Contributor

@hatch01 hatch01 commented Apr 17, 2024

Description of changes

Add the package clang-uml

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/1016/126

Copy link
Member

@RossComputerGuy RossComputerGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great aside from a few duped empty lines.

pkgs/by-name/cl/clang-uml/package.nix Show resolved Hide resolved
pkgs/by-name/cl/clang-uml/package.nix Show resolved Hide resolved
pkgs/by-name/cl/clang-uml/package.nix Outdated Show resolved Hide resolved
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/3870

@hatch01
Copy link
Contributor Author

hatch01 commented Jun 3, 2024

@pogobanane is it ok for you that I use your work on clang-uml for nix packaging in this pr here (PR)
And should I use your wrapper, or is there a method to use the wrapper of clang directly in nixpkgs ?

@pogobanane
Copy link
Member

@pogobanane is it ok for you that I use your work on clang-uml for nix packaging in this pr here (bkryza/clang-uml#273)
And should I use your wrapper, or is there a method to use the wrapper of clang directly in nixpkgs ?

We should merge this clang-uml: init first. Afterwards we can consider building a small, shared abstraction:

We already have that same wrapper here https://github.com/NixOS/nixpkgs/blob/0e2ddadf231ae164c333ac4d9e093c7ae21b970e/pkgs/development/tools/analysis/include-what-you-use/wrapper and here https://github.com/NixOS/nixpkgs/blob/master/pkgs/development/tools/clang-tools/wrapper. However for clang-uml-wrapped, we run the binary in a different way, so we can't copy paste them. We could move the buildcpath() function and exports into a common file that is sourced by the app-respective wrappers. I'm not sure where to put such a lib-clang-wrapper.sh though. There is no precedent of putting it into nixpkgs/lib. We could perhaps integrate it into the llvmPackages, but i dont think that is worth the hassle.

Copy link
Member

@pogobanane pogobanane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I tested a previous version of this patch with my own code.

@Mic92 Mic92 merged commit 999b26a into NixOS:master Jun 5, 2024
24 checks passed
@hatch01 hatch01 deleted the clang-uml branch August 16, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants