xmltoman: init at 0.6 #305096
xmltoman: init at 0.6 #305096
Conversation
pkgs/by-name/xm/xmltoman/package.nix
Outdated
| perl538Packages.XMLTokeParser | ||
| ]; | ||
|
|
||
| buildPhase = '' |
There was a problem hiding this comment.
Please split postPatch buildPhase and preInstall.
There was a problem hiding this comment.
Didn't resolve this. Also overriding phases need adding runHook: runHook preBuild and runHook postBuild
There was a problem hiding this comment.
you mean i did not resolve it by splitting it into buildPhase and preInstall? if so which part goes into preInstall?
There was a problem hiding this comment.
Didn't look into this carefully. You can put all these to installPhase.
Tochiaha
force-pushed
the
xmltoman
branch
5 times, most recently
from
003bef2
to
d861e9a
Compare
|
Result of 1 package failed to build:
|
Tochiaha
force-pushed
the
xmltoman
branch
6 times, most recently
from
1cf25db
to
c49813c
Compare
Tochiaha
force-pushed
the
xmltoman
branch
2 times, most recently
from
130e2a3
to
90fb088
Compare
|
@fabaff any help here? |
pkgs/by-name/xm/xmltoman/package.nix
Outdated
| perl538Packages.XMLTokeParser | ||
| ]; | ||
|
|
||
| buildPhase = '' |
There was a problem hiding this comment.
Didn't resolve this. Also overriding phases need adding runHook: runHook preBuild and runHook postBuild
Tochiaha
force-pushed
the
xmltoman
branch
3 times, most recently
from
86c9b29
to
b8b942d
Compare
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/3838 |
Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.