Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

veracrypt: add patch to support sudo-rs #305102

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

id3v1669
Copy link
Contributor

@id3v1669 id3v1669 commented Apr 18, 2024

Description of changes

Added patch that removes extra flag -p from sudo command in veracrypt.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Notes

sudo-rs has fewer options and doesn't provide -p flag.
Because of that, instead of mounting/dismounting app throws a message "Failed to obtain administrator privileges: invalid option provided".

Optional patch was created due to developers response in opened issue

Defaulted to false as might cause problems for users that us regular sudo.


Question

I am not interested in maintaining this package; I just want to apply the patch. Am I required to add myself to the maintainers' list?


Add a 👍 reaction to pull requests you find important.

@id3v1669
Copy link
Contributor Author

@ofborg build veracrypt

@id3v1669
Copy link
Contributor Author

Result of nixpkgs-review pr 305102 run on x86_64-linux 1

1 package built:
  • veracrypt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants