-
-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nixos/filesender: init #305132
nixos/filesender: init #305132
Conversation
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/3810 |
Implementation mostly looks good, I'd just split up the modules into two separate files. |
Does new simplesamlphp module looks okay? |
Strange, "Build NixOS manual" fails, but I already deleted mdDoc usage. |
Please rebase and drop the merge commit. This makes resolving merge conflicts down the line in some situations near impossible. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably split this PR up a bit (eg the new format or one per service) otherwise it will probably take a good while until it will get merged.
Co-authored-by: Sandro <sandro.jaeckel@gmail.com>
Co-authored-by: Sandro <sandro.jaeckel@gmail.com>
Co-authored-by: Sandro <sandro.jaeckel@gmail.com>
I've split this PR to two separate ones: @SuperSandro2000 Is it supposed to look like this? |
Description of changes
Added two packages simplesamlphp (Authorization for PHP) and filesender (File sharing server), nixos module for filesender and NixOS test to test module functionality.
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.