nixos/filesender: init #305132
Closed
nixos/filesender: init #305132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/3810 |
balsoft
reviewed
Apr 19, 2024
balsoft
reviewed
Apr 19, 2024
balsoft
reviewed
Apr 19, 2024
balsoft
reviewed
Apr 19, 2024
|
Implementation mostly looks good, I'd just split up the modules into two separate files. |
Does new simplesamlphp module looks okay? |
|
Strange, "Build NixOS manual" fails, but I already deleted mdDoc usage. |
|
Please rebase and drop the merge commit. This makes resolving merge conflicts down the line in some situations near impossible. |
Co-authored-by: Sandro <sandro.jaeckel@gmail.com>
Co-authored-by: Sandro <sandro.jaeckel@gmail.com>
Co-authored-by: Sandro <sandro.jaeckel@gmail.com>
|
I've split this PR to two separate ones: @SuperSandro2000 Is it supposed to look like this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Added two packages simplesamlphp (Authorization for PHP) and filesender (File sharing server), nixos module for filesender and NixOS test to test module functionality.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.