-
-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
knot-resolver: add luaPackages.psl #305154
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It won't build for me
$ nix build -f. luajitPackages.psl
> Error: Could not find header file for PSL
> No file libpsl.h in /nix/store/3gc64ag4cav0y40pk5zd75cs58q25a9l-wrap-lua-hook/include
> No file libpsl.h in /nix/store/h523pxxyypw7bk977kirhdzjjv52gzcs-luajit-2.1.1693350652/include
> No file libpsl.h in /nix/store/xfc3kaxwvya9i0589b8gn9cnr2h6ah2p-libpsl-0.21.5-bin/include
> You may have to install PSL in your system and/or pass PSL_DIR or PSL_INCDIR to the luarocks command.
> Example: luarocks install psl PSL_DIR=/usr/local
Note: it's been unclear for us whether that randomized approach improves privacy or makes it worse. We haven't implemented support for this in the knot-resolver 6.x configuration model so far, BTW. |
The other alternative, to send all requests to all servers, would generate more traffic and we use it more to spread the requests somewhat to all servers. |
I've test this on 23.11 and funnily I think #292260 broke the naive lua approach. pkgconfig file seems correct. |
I'm not aware of such an alternative that increases traffic amount. |
Now it looks good to me. Though the http module won't work until fixes in PR #303527 (guarded by eval error now). |
I might have mixed that up with dnsmasq 😅 I did to many DNS things yesterday |
9adde29
to
ab3fd44
Compare
You broke this again. |
🤦🏼 |
ab3fd44
to
ccb1114
Compare
ccb1114
to
f358fe9
Compare
Can we merge this? |
Successfully created backport PR for |
Description of changes
This basically adds support for
policy.slice_randomize_psl()
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.