nixos/akkoma: Fix media proxy URLs after upgrade #305155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The upgrade of akkoma to 3.12.1 required to specify media upload and media proxy URLs by default. The default value for media proxy was wrong, leading to broken `example.com/media/proxy/[...]` URLs. As descried in the [upgrade guide](https://meta.akkoma.dev/t/akkoma-stable-2024-03-securer-i-barely-know-her/681#explicit-upload-and-media-proxy-domains-5), the media proxy `base_url` should be set to `https://example.com` (without a path component). The suffix already contains `proxy/[...]`, which gives the expected URLs.
Mynacol
added
9.needs: port to stable
LeSuisse
reviewed
Apr 22, 2024
There was a problem hiding this comment.
Change looks coherent to me. @tcmal and @illdefined can you check since you reviewed the last change?
tcmal
approved these changes
Apr 24, 2024
illdefined
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
The upgrade of akkoma to 3.12.1 in #300343 required to specify media upload and media proxy URLs by default. The default value for media proxy was wrong, leading to broken
example.com/media/proxy/[...]URLs.As descried in the upgrade guide, the media proxy
base_urlshould be set tohttps://example.com(without a path component). The suffix already containsproxy/[...], which gives the expected URLs.All media was broken after the update. Setting the media proxy
base_urlto the committed values fixed new media. Old media in the meantime is still broken.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.
@LeSuisse @illdefined