Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sphinxcontrib-moderncmakedomain init at 3.29.0 #305426

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

sphinxcontrib-moderncmakedomain init at 3.29.0 #305426

wants to merge 2 commits into from

Conversation

jhol
Copy link
Contributor

@jhol jhol commented Apr 20, 2024

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/3937

@jhol jhol force-pushed the sphinxcontrib-moderncmakedomain branch from 99a89ea to 5bc0cab Compare June 3, 2024 17:25
@jhol jhol force-pushed the sphinxcontrib-moderncmakedomain branch from 5bc0cab to 44a0d41 Compare July 12, 2024 23:28
@jhol jhol requested a review from natsukium as a code owner July 12, 2024 23:28
@jhol jhol changed the title sphinxcontrib-moderncmakedomain init at 3.27.0 sphinxcontrib-moderncmakedomain init at 3.29.0 Jul 12, 2024
@jhol jhol force-pushed the sphinxcontrib-moderncmakedomain branch from 44a0d41 to 2245bbf Compare July 12, 2024 23:31
@jhol jhol force-pushed the sphinxcontrib-moderncmakedomain branch 2 times, most recently from feb1e31 to 27a62e7 Compare August 2, 2024 00:25
@jhol jhol force-pushed the sphinxcontrib-moderncmakedomain branch from 27a62e7 to 8113205 Compare August 2, 2024 00:28
@jhol
Copy link
Contributor Author

jhol commented Aug 9, 2024

I think this should be good to go now. Is there anything I can do to help get this accepted?

natsukium
natsukium reviewed Aug 10, 2024
View reviewed changes
pkgs/development/python-modules/sphinxcontrib-moderncmakedomain/default.nix
Comment on lines +22 to +25
nativeBuildInputs = [
hatchling
sphinx
];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
nativeBuildInputs = [
hatchling
sphinx
];
build-system = [ hatchling ];
dependencies = [ sphinx ];

We use build-system and dependencies for python dependencies.
https://github.com/NixOS/nixpkgs/blob/master/doc/languages-frameworks/python.section.md#buildpythonpackage-parameters-buildpythonpackage-parameters

Also, following the upstream, sphinx should go to dependencies.
https://github.com/scikit-build/moderncmakedomain/blob/b4cdb0089ad40189f4cffeab7f859265da599336/pyproject.toml#L40-L42

pkgs/development/python-modules/sphinxcontrib-moderncmakedomain/default.nix
nativeCheckInputs = [
defusedxml
pytestCheckHook
sphinx
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
sphinx

pkgs/development/python-modules/sphinxcontrib-moderncmakedomain/default.nix
];

pythonNamespaces = [ "sphinxcontrib" ];

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you enable pythonImportsCheck?
https://github.com/NixOS/nixpkgs/blob/master/doc/languages-frameworks/python.section.md#using-pythonimportscheck-using-pythonimportscheck

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@natsukium natsukium natsukium left review comments

Assignees
No one assigned
Labels
6.topic: python 8.has: maintainer-list (update) 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jhol @nixos-discourse @SuperSandro2000 @natsukium