-
-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
zig: 0.11 -> 0.12 #306077
zig: 0.11 -> 0.12 #306077
Conversation
Technically, the PR is not about fixing builds, but bumping default Zig version to 0.12 (which should be in a separate PR), and marking builds that succeed on Hydra as broken (which I don't really agree with). The reason why builds are broken locally could, unfortunately, be obscure on macOS. I'm aware that having Xcode Command Line Tools, or even XQuartz installed, can break some builds. Instead of marking them as broken, I'd suggest seeing if the build works in a fresh macOS and Nix installation on a virtual machine. |
Yeah I see what you're saying. By "fix" I meant fix non-reproducibility, as a non-reproducible build can't be relied upon to not break on an input update, but I guess it's not necessarily broken per se.
Even with sandboxing? That's annoying.
Will do. |
@wegank The build does not succeed, even in a fresh macOS VM:
My strong suspicion is that it does succeed on older versions of macOS, but I have no way of testing this hypothesis. However, I agree with your general assessment, this is a version upgrade. Additionally, I tried to upgrade the versions of all the packages depending on zig_0_11, and most failed to build, so clearly 0.12 is not supported widely yet. Sooo, I guess we just leave all the zig stuff as is and hope there's no input update until the release that breaks it? |
Oh, that's sad.
You can still proceed with the version upgrade, just pin the failing packages to Zig 0.11. You can check #248153 to see how this was done. |
We decided a long time ago to pin all references to Zig in packages, since it is not stable enough. In other words, always use |
@AndersonTorres Yes, I noticed. There are a few packages that reference zig directly (none of those broke), but most already specify zig_0_11 in their inputs. I'll add the ones that the upgrade worked for plus the review suggestions next week Wednesday. |
687617c
to
e6c4f9f
Compare
e6c4f9f
to
8148ea5
Compare
8148ea5
to
968e2c9
Compare
So I've gone through and tried to upgrade as many packages as possible, most failed, which is not a problem, but one blocks this PR; zls, the zig language server. Upstream updated it 5 days ago to be compatible with zig 0.12, and a PR for updating it exists already: #308248 That has to be merged before this PR, otherwise something like |
We should add some passthru.tests for ZLS. |
968e2c9
to
3a69789
Compare
@AndersonTorres I agree that would be best, though I'm unsure if I can land it in this PR. I played around a bit, and I guess one thing to do would be something like this:
But that is only a test inside of I thought about adding a |
The idea is not to test versions, but the softwares themselves. Something like we do with live555+vlc. Let's postpone this to a future PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just merged the zls
update — #308248 — and this looks good to go.
@ofborg build backlight-auto |
08f405e
to
12c39e8
Compare
This upgrades the default version of zig to zig_0_12, which builds reproducibly on darwin. Fixes NixOS#299091. Also upgrades all packages compatible with zig 0.12 to that version. I tried to upgrade packages currently pinning 0.11 as well, but only a few worked.
12c39e8
to
a38793e
Compare
Result of 7 packages built:
|
This upgrades the default version of zig to zig_0_12, which builds reproducibly on darwin. Fixes NixOS#299091. Also upgrades all packages compatible with zig 0.12 to that version. I tried to upgrade packages currently pinning 0.11 as well, but only a few worked. Co-authored-by: Weijia Wang (wegank) <contact@weijia.wang>
This upgrades the default version of zig to zig_0_12, which builds reproducibly on darwin,
and marks all older versions as broken on darwin.Fixes #299091.
Also pins all packages compatible with zig 0.12 to that version.
I tried to upgrade packages currently pinning 0.11 as well, but only a
few worked.
Supersedes #304369
Description of changes
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.