-
-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
testers: add more parameters, add testVersion to my maintained packages #306307
base: master
Are you sure you want to change the base?
Conversation
4a7b6bb
to
0761faf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! I do have a little feedback, but other than that and needing tests I'd approve it.
Thank you all for the feedback, I still intend to continue this but it may take a bit. |
If you are too busy, or are getting overwhelmed in any way, I can also address the feedback myself and merge. It's also fine if you want to do it yourself and need time for whatever reason, I just wanted to make clear you have the option to let us do the rest: after all, teamwork makes the dream work ❤️ |
I'm not overwhelmed or anything, it's just not very high on my priority list right now. If anyone wants to take over this (or any of my other PRs for that matter), they should feel absolutely welcome to do so. You're not stealing anything away from me here ;) |
When any aspect of the command to show the version needed to change, the entire command would have to be declared in full. This allows directly customising those aspects individually.
It's not that important but this is minimally more useful than an empty file.
buildGoModule does not support finalAttrs
Some programs exit with non-zero exit code for some reason. It should still be possible to run the version smoke check in that case.
0761faf
to
9c3bfd1
Compare
Rebased to address merge conflict |
43b8098
to
1b12cc3
Compare
If the commits touching my packages are causing any issue, feel free to drop them. I can put those in a separate PR following this one. |
They aren't, don't worry <3 |
The build issue on
|
Description of changes
When any aspect of the command to show the version needed to change, the entire
command would have to be declared in full. This allows directly customising
those aspects individually.
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.