Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vis: 0.8 -> 0.9 #308421

Merged
merged 2 commits into from
May 2, 2024
Merged

vis: 0.8 -> 0.9 #308421

merged 2 commits into from
May 2, 2024

Conversation

r-ryantm
Copy link
Contributor

@r-ryantm r-ryantm commented May 2, 2024

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/martanne/vis/releases.

meta.description for vis is: A vim like editor

meta.homepage for vis is: https://github.com/martanne/vis

Updates performed
  • Version update
To inspect upstream changes
Impact

Checks done


  • built on NixOS
  • The tests defined in passthru.tests, if any, passed
  • found 0.9 with grep in /nix/store/y42gcp0xjxlkd10s4d4h2xs6lnhskbxl-vis-0.9
  • found 0.9 in filename of file in /nix/store/y42gcp0xjxlkd10s4d4h2xs6lnhskbxl-vis-0.9

Rebuild report (if merged into master) (click to expand)
2 total rebuild path(s)

2 package rebuild(s)

First fifty rebuilds by attrpath

vis
Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/y42gcp0xjxlkd10s4d4h2xs6lnhskbxl-vis-0.9 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.

Or, build yourself:

nix-build -A vis https://github.com/r-ryantm/nixpkgs/archive/c6861e8f0f0c4983ba0777864fa1bb2f4dfe8054.tar.gz

Or:

nix build github:r-ryantm/nixpkgs/c6861e8f0f0c4983ba0777864fa1bb2f4dfe8054#vis

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/y42gcp0xjxlkd10s4d4h2xs6lnhskbxl-vis-0.9
ls -la /nix/store/y42gcp0xjxlkd10s4d4h2xs6lnhskbxl-vis-0.9/bin


Pre-merge build results

We have automatically built all packages that will get rebuilt due to
this change.

This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.

Result of nixpkgs-review --extra-nixpkgs-config '{ allowInsecurePredicate = x: true; }' run on x86_64-linux 1

1 package built:
  • vis

Maintainer pings

cc @vrthra @RamKromberg for testing.

@RamKromberg
Copy link
Contributor

Tested using the Cachix build to work properly on stable.

@sikmir
Copy link
Member

sikmir commented May 2, 2024

Result of nixpkgs-review pr 308421 run on x86_64-linux 1

1 package built:
  • vis

Result of nixpkgs-review pr 308421 run on x86_64-darwin 1

1 package built:
  • vis

@sikmir
Copy link
Member

sikmir commented May 2, 2024

Note that default theme changed:

$ ls -la /nix/store/qg3qiv4sppwj178sr0v8jpnj32wq98pb-vis-0.8/share/vis/themes/
total 32
dr-xr-xr-x  8 root  wheel   256 Jan  1  1970 ./
dr-xr-xr-x  9 root  wheel   288 Jan  1  1970 ../
-r--r--r--  1 root  wheel  1401 Jan  1  1970 dark-16.lua
lrwxr-xr-x  1 root  wheel    11 Jan  1  1970 default-16.lua@ -> dark-16.lua
lrwxr-xr-x  1 root  wheel    11 Jan  1  1970 default-256.lua@ -> zenburn.lua
-r--r--r--  1 root  wheel  1403 Jan  1  1970 light-16.lua
-r--r--r--  1 root  wheel  2388 Jan  1  1970 solarized.lua
-r--r--r--  1 root  wheel  1432 Jan  1  1970 zenburn.lua
$ ls -la /nix/store/n32h38lmki87333kxbqnr40vgy6p2a82-vis-0.9/share/vis/themes/
total 16
dr-xr-xr-x 6 root wheel  192 Jan  1  1970 .
dr-xr-xr-x 9 root wheel  288 Jan  1  1970 ..
-r--r--r-- 1 root wheel 4667 Jan  1  1970 base-16.lua
lrwxr-xr-x 1 root wheel   11 Jan  1  1970 default.lua -> base-16.lua
-r--r--r-- 1 root wheel 2388 Jan  1  1970 solarized.lua
-r--r--r-- 1 root wheel 1480 Jan  1  1970 zenburn.lua

See martanne/vis#1154

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label May 2, 2024
@sikmir sikmir merged commit 2715377 into NixOS:master May 2, 2024
24 of 25 checks passed
@r-ryantm r-ryantm deleted the auto-update/vis branch May 2, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants