olympus: init at 24.07.06.02

[Petingoso]

This is an attempt to package Olympus, a GUI for installing Everest and managing Celeste mods.
This is based on this draft, with the authors permission.

It maintains the previous issue of not being able to launch Steam
versions of Celeste from the command line but that's not feasible
without upstream changes.

I only have to note that it has a popup complaining about
finishing the installation but that's due to xdg-mime
x-scheme-handler/everest not being set.

Finally I want to note that it depends on lua51Packages.nfd, which
is broken while this
isn't merged so currently has the fix there.

Finally, Lönn works
as expected, being the installation managed by the program.

Ahorn is deprecated (in favor of Loenn) and it crashes over trying to run dynamic
executables

fixes #162887
Closes #295258

Description of changes

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[DontEatOreo]

I would recommend you have the maintainers commit to be the first one and squash 2eeae0f01e5224dc59e9bd13ebf71d5d9dc77794 into a75b006a4fc0b1a837fcebf04212eafd3218ec88 so you can comply with the Commit Conventions

[Petingoso]

Just cherry picked the commits from https://github.com/NixOS/nixpkgs/pull/309026/commits to make the package cleaner
Edit: Commits have been removed as they have been merged.

[IogaMaster]

This seems to work great!

[DontEatOreo]

Last commit should be squashed

[UlyssesZh]

@ofborg eval

[UlyssesZh]

I think you need to cherry-pick f705702?

[L1Z3]

Just tried this, and Lönn doesn't seem to be able to launch for me:

Expand for log

Error

[love "boot.lua"]:276: utils/filesystem.lua:2: module 'nfd' not found:
no field package.preload['nfd']no file 'selene/selene/lib/nfd.lua'
no file 'selene/selene/lib/nfd/init.lua'
no file 'nfd/nfd.lua'
no file 'olympUI/nfd.lua'
no file 'olympUI/nfd/init.lua'
no file 'nfd.lua'
no file 'nfd/init.lua'
no 'nfd' in LOVE game directories.
no file 'nfd' in LOVE paths.
no file './nfd.lua'
no file '/nix/store/8apx02hrz7bb9pmhcw88dj2k6jgj7pxl-luajit-2.1.1693350652/share/luajit-2.1/nfd.lua'
no file '/usr/local/share/lua/5.1/nfd.lua'
no file '/usr/local/share/lua/5.1/nfd/init.lua'
no file '/nix/store/8apx02hrz7bb9pmhcw88dj2k6jgj7pxl-luajit-2.1.1693350652/share/lua/5.1/nfd.lua'
no file '/nix/store/8apx02hrz7bb9pmhcw88dj2k6jgj7pxl-luajit-2.1.1693350652/share/lua/5.1/nfd/init.lua'
no file '/nix/store/z64mi9bhk1ypkl1znq9h4a3yf60500p1-nfd-22.12/lib/lua/5.1/nfd.so'
no file '/nix/store/77bibyn8ar44jfp2g3hk607jh4xaa0xj-lua5.1-subprocess-bfa8e9/lib/lua/5.1/nfd.so'
no file '/nix/store/bds733hnlwi1nmx4j2q9ipw8im5wc386-lua5.1-lsqlite3-0.9.6-1/lib/lua/5.1/nfd.so'


Traceback

[love "callbacks.lua"]:228: in function 'handler'
[C]: in function 'error'
[C]: in function 'xpcall'
[C]: in function 'xpcall'

[Petingoso]

Huh I think I didn't put it as a runtime input, I'm checking if that might be the issue.

[Petingoso]

Just tried this, and Lönn doesn't seem to be able to launch for me:
Expand for log

I figured it out, when I removed the patch from nfd I was using "nfd" instead of lua51Packages.nfd, meaning I wasn't installing lua modules.
I'll push the fix right now

[L1Z3]

Works great now, thanks!

[IogaMaster]

Thanks just started using Loenn

[L1Z3]

Can be bumped to latest commit hash (5f3e40687eb825c57021f52d83a3bc9a82c04bdb) (which has official version number 24.07.06.02 according to the Azure Pipeline page.)

[Petingoso]

I'll just check if stuff works fine and if all's good I'll edit the PR then.

[Petingoso]

Not sure if its reproduceable for anyone else but going from 6b4ceee45b51b913cf1d50bfb3ae645b21bba4f1 to 8f6e3ec1ab520904b1e0429ac194541d68a897b5 ( the following commit) gives an error relating to luajit-request.luajit-request.init. I'm trying to figure out what might be the issue but it doesn't seem to be making sense.

EDIT: it seems to be missing luajit-request? I dont see why it should be called from that commit

[L1Z3]

No, I don't get that error on commit 8f6e3ec1ab520904b1e0429ac194541d68a897b5 or on the latest commit. On both commits, it builds and runs fine for me. Are you doing something within Olympus that's causing the error to happen?

[Petingoso]

No, I don't get that error on commit 8f6e3ec1ab520904b1e0429ac194541d68a897b5 or on the latest commit. On both commits, it builds and runs fine for me. Are you doing something within Olympus that's causing the error to happen?

I'm simply going from

      rev = "6b4ceee45b51b913cf1d50bfb3ae645b21bba4f1";
      fetchSubmodules = true; # Required. See upstream's README.
      hash = "sha256-FtvTELf8EZCkoAmMbgwxftxXOzdXy0P69RRMyPlRXUA=";

to

      rev = "5f3e40687eb825c57021f52d83a3bc9a82c04bdb";
      fetchSubmodules = true; # Required. See upstream's README.
      hash = "sha256-aSE0g2YzmFnbSRB8QZ9B+H1HCn92HZqKunVtbdn7oQc=";

and just launching the binary gives me an error. Are you bumping the revision in another way?

pre-initializing
cwd:	/nix/store/x1lzrlzjp8mwy7qj0s2yhfz7kkbb5wyg-olympus-24.04.23.02/lib/olympus
src:	/nix/store/x1lzrlzjp8mwy7qj0s2yhfz7kkbb5wyg-olympus-24.04.23.02/lib/olympus
storageDir:	/home/petnix/.config/Olympus
luajit-request not loaded
module 'luajit-request.luajit-request.init' not found:
	no field package.preload['luajit-request.luajit-request.init']
	no 'luajit-request/luajit-request/init' in LOVE game directories.
	no file 'luajit-request/luajit-request/init' in LOVE paths.
	no file './luajit-request/luajit-request/init.lua'
	no file '/nix/store/kvc6zy9pavv5k2vd419zzb992kwjjqqr-luajit-2.1.1713773202/share/luajit-2.1/luajit-request/luajit-request/init.lua'
	no file '/usr/local/share/lua/5.1/luajit-request/luajit-request/init.lua'
	no file '/usr/local/share/lua/5.1/luajit-request/luajit-request/init/init.lua'
	no file '/nix/store/kvc6zy9pavv5k2vd419zzb992kwjjqqr-luajit-2.1.1713773202/share/lua/5.1/luajit-request/luajit-request/init.lua'
	no file '/nix/store/kvc6zy9pavv5k2vd419zzb992kwjjqqr-luajit-2.1.1713773202/share/lua/5.1/luajit-request/luajit-request/init/init.lua'
	no file '/nix/store/gqsjg9k1gvyrfpv5h5vgp9pky4gz0dpa-lua5.1-nfd-scm-1/lib/lua/5.1/luajit-request/luajit-request/init.so'
	no file '/nix/store/br24aizl64vk638xkw7gq479grz4fxnq-lua5.1-subprocess-bfa8e9/lib/lua/5.1/luajit-request/luajit-request/init.so'
	no file '/nix/store/6p90k0szyd052csv8x4cdzs35m77k5h6-lua5.1-lsqlite3-0.9.6-1/lib/lua/5.1/luajit-request/luajit-request/init.so'
	no file '/nix/store/gqsjg9k1gvyrfpv5h5vgp9pky4gz0dpa-lua5.1-nfd-scm-1/lib/lua/5.1/luajit-request.so'
	no file '/nix/store/br24aizl64vk638xkw7gq479grz4fxnq-lua5.1-subprocess-bfa8e9/lib/lua/5.1/luajit-request.so'
	no file '/nix/store/6p90k0szyd052csv8x4cdzs35m77k5h6-lua5.1-lsqlite3-0.9.6-1/lib/lua/5.1/luajit-request.so'
Error: [love "boot.lua"]:276: utils.lua:24: module 'ui.utils' not found:
	no field package.preload['ui.utils']
	no 'ui/utils' in LOVE game directories.
	no file 'ui/utils' in LOVE paths.
	no file './ui/utils.lua'
	no file '/nix/store/kvc6zy9pavv5k2vd419zzb992kwjjqqr-luajit-2.1.1713773202/share/luajit-2.1/ui/utils.lua'
	no file '/usr/local/share/lua/5.1/ui/utils.lua'
	no file '/usr/local/share/lua/5.1/ui/utils/init.lua'
	no file '/nix/store/kvc6zy9pavv5k2vd419zzb992kwjjqqr-luajit-2.1.1713773202/share/lua/5.1/ui/utils.lua'
	no file '/nix/store/kvc6zy9pavv5k2vd419zzb992kwjjqqr-luajit-2.1.1713773202/share/lua/5.1/ui/utils/init.lua'
	no file '/nix/store/gqsjg9k1gvyrfpv5h5vgp9pky4gz0dpa-lua5.1-nfd-scm-1/lib/lua/5.1/ui/utils.so'
	no file '/nix/store/br24aizl64vk638xkw7gq479grz4fxnq-lua5.1-subprocess-bfa8e9/lib/lua/5.1/ui/utils.so'
	no file '/nix/store/6p90k0szyd052csv8x4cdzs35m77k5h6-lua5.1-lsqlite3-0.9.6-1/lib/lua/5.1/ui/utils.so'
	no file '/nix/store/gqsjg9k1gvyrfpv5h5vgp9pky4gz0dpa-lua5.1-nfd-scm-1/lib/lua/5.1/ui.so'
	no file '/nix/store/br24aizl64vk638xkw7gq479grz4fxnq-lua5.1-subprocess-bfa8e9/lib/lua/5.1/ui.so'
	no file '/nix/store/6p90k0szyd052csv8x4cdzs35m77k5h6-lua5.1-lsqlite3-0.9.6-1/lib/lua/5.1/ui.so'
stack traceback:
	[love "boot.lua"]:352: in function <[love "boot.lua"]:348>
	[C]: in function 'error'
	[love "boot.lua"]:276: in function <[love "boot.lua"]:126>
	[C]: in function 'xpcall'
	[love "boot.lua"]:362: in function <[love "boot.lua"]:355>
	[C]: in function 'xpcall'

[L1Z3]

Nope, I did the same (though I seem to have a different hash from you?), see my copy of the package here.

[Petingoso]

somehow that was the issue? I used nix-prefetch-github but if the hash was "wrong" I would have expected the cloning to fail

[L1Z3]

Interesting, I don't know why that happens but I've definitely had weird errors happen when updating a package without touching the hash, so I've gotten into the habit of removing the hash whenever I touch the package version.

[mirrorcult]

been using this for a couple days and it works great

[IogaMaster]

been using this for a couple days and it works great

Same, Celeste with mods and Loenn are working very well. No complaints here.

I really appreciate your work here Petingoso

[Petingoso]

been using this for a couple days and it works great

Same, Celeste with mods and Loenn are working very well. No complaints here.

I really appreciate your work here Petingoso

Thanks but most of the work is @UlyssesZh and not me, I only tweaked to get things working but the base package is all theirs.