-
-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ebusd service argument passing #309517
Conversation
6f759ef
to
0178554
Compare
I'm not familiar with the nix language and suspect this fix may not be the best approach, open to suggestions. @nathan-gs are you able to recommend anyone that might help with improving my fix? |
3b6e3a8
to
b9a463a
Compare
@nathan-gs this is ready for review and fixes ebusd in nixos, happy to request a review from others if you're short on time :) |
For me it looks good! However let's also have a review from some experts of |
b9a463a
to
5458b62
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good!
# how to separate an option from its flag; | ||
# by default, there is no separator, so option `-c` and value `5` | ||
# would become ["-c" "5"]. | ||
# This is useful if the command requires equals, for example, `-c=5`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately this is currently not rendered in the reference manual. If you're interested in improving that, feel free to make a PR to move these into the doc comment above the function! Check out the part on 'function arguments' here to see the convention for that :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the tip - would you mind taking a look at #315820? Also, do you have a link to the reference doc? I can't find where cli.nix
appears when I've been searching
Description of changes
This resolves a bug introduced in #308500 / #264893, where ebusd arguments were changed from
--scanconfig=all
to--scanconfig all
with the use ofcli.toGNUCommandLineShell
.The bug is an unfortunate result of
ebusd
's argument parsing - the arguments must be separated by equals signs.Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)