lib.systems.elaborate: set hasSharedLibraries=true for ghcjs platform #309879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ghcjs platform currently supports only shared libraries, so hasSharedLibraries should be true. The absense of this attribute didn't cause errors prior to recent refactorings of lib.systems, but as for now attempt to build any package from pkgsCross.ghcjs.haskell.packages.ghc98 fails with `attribute 'sharedLibrary' missing`
|
That particular evaluation error is fixed after #309089. I haven't touched this flag because I'm not sure what should necessarily go there. The platform meta data is usually used to determine what the produced libraries will have for an extension. In |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Ghcjs platform currently supports only shared libraries, so hasSharedLibraries should be true.
The absense of this attribute didn't cause errors prior to recent refactorings of lib.systems, but as for now attempt to build any package from pkgsCross.ghcjs.haskell.packages.ghc98 fails with
attribute 'sharedLibrary' missingThings done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.