Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chatzone-desktop: init at 5.2.1 #311654

Merged
merged 2 commits into from
Aug 27, 2024

Conversation

JarvisCraft
Copy link
Contributor

Description of changes

Chatzone(-desktop) is a corporate fork of Mattermost(-desktop) with some performance improvements. It is maintained by Ozon Tech and is available as an x86_64 AppImage.

Things done

  • Built on platform(s)
    • x86_64-linux
  • Tested, as applicable:
    • not applicable
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • none required
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Copy link
Member

@yunfachi yunfachi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, these two commits should be left. The other commits should be squashed.

maintainers: add progrm_jarvis
chatzone-desktop: init at 5.1.10

pkgs/by-name/ch/chatzone-desktop/package.nix Outdated Show resolved Hide resolved
@JarvisCraft
Copy link
Contributor Author

@yunfachi, thanks for your review!

I've removed the use of with lib; and reordered+squashed the commits.

@JarvisCraft JarvisCraft requested a review from yunfachi May 16, 2024 23:35
@JarvisCraft
Copy link
Contributor Author

@SuperSandro2000 thanks for your review! All fixed
I've also populated more useful desktop entry metadata.

I've also removed the update script for now since the URLs have changed and there is no good alternative for discovering the latest version for now (for history, the last commit with the update script was 39e70d5f2169436df7cc841aba976717deb613b7).

@JarvisCraft
Copy link
Contributor Author

I've also rebased to master applying the required nixfmt fixes

@JarvisCraft JarvisCraft force-pushed the add-chatzone-desktop branch 3 times, most recently from d5ef90c to b942a33 Compare July 28, 2024 23:17
@JarvisCraft
Copy link
Contributor Author

Tested the new approach to the icons, it works as intended:

image

@JarvisCraft JarvisCraft changed the title chatzone-desktop: init at 5.1.10 chatzone-desktop: init at 5.2.1 Aug 6, 2024
@JarvisCraft
Copy link
Contributor Author

Bumped the version to 5.2.1

@JarvisCraft
Copy link
Contributor Author

@SuperSandro2000, thanks, pushed the fixes

@JarvisCraft
Copy link
Contributor Author

JarvisCraft commented Aug 13, 2024

Hi @SuperSandro2000, is there anything else to be changed before the PR can be merged?

@SuperSandro2000 SuperSandro2000 merged commit 6a05230 into NixOS:master Aug 27, 2024
27 of 28 checks passed
@JarvisCraft
Copy link
Contributor Author

Thanks!

@JarvisCraft JarvisCraft deleted the add-chatzone-desktop branch August 29, 2024 09:08
@JarvisCraft JarvisCraft added the backport release-24.05 Backport PR automatically label Sep 3, 2024
Copy link
Contributor

github-actions bot commented Sep 3, 2024

Successfully created backport PR for release-24.05:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants