Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gcc13: 13.2.0 -> 13.3.0 #313489

Merged
merged 1 commit into from
May 30, 2024
Merged

gcc13: 13.2.0 -> 13.3.0 #313489

merged 1 commit into from
May 30, 2024

Conversation

trofi
Copy link
Contributor

@trofi trofi commented May 21, 2024

Changes: https://gcc.gnu.org/gcc-13/changes.html

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@trofi
Copy link
Contributor Author

trofi commented May 22, 2024

Rebased past merge conflict against recently added gcc-14.

@JohnRTitor
Copy link
Contributor

@ofborg build gcc13

Copy link
Member

@vcunat vcunat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

error: hash mismatch in fixed-output derivation '/nix/store/m094ajwgzkikf2w82smda5fg0cbfsb2n-gcc-13-darwin-aarch64-support.patch.drv':
         specified: sha256-xekjZDDvbtvdp96axwv3niFigHekgyLOx/PwZMz8JD0=
            got:    sha256-RBTCBXIveGwuQGJLzMW/UexpUZdDgdXprp/G2NHkmQo=

With that fixed it builds on aarch64-darwin for me (this change atop nixpkgs master).

@trofi
Copy link
Contributor Author

trofi commented May 30, 2024

error: hash mismatch in fixed-output derivation '/nix/store/m094ajwgzkikf2w82smda5fg0cbfsb2n-gcc-13-darwin-aarch64-support.patch.drv':
         specified: sha256-xekjZDDvbtvdp96axwv3niFigHekgyLOx/PwZMz8JD0=
            got:    sha256-RBTCBXIveGwuQGJLzMW/UexpUZdDgdXprp/G2NHkmQo=

Ah, I completely missed that it's fetchpatch and not fetchurl and used nix-prefetch-url to get the initial hash. Updated. Thank you!

@vcunat vcunat merged commit 5d44b1a into NixOS:staging May 30, 2024
6 of 7 checks passed
@trofi trofi deleted the gcc-13-update branch May 30, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants