nixos/containerd: remove LimitNOFILE from service #313507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Having `LimitNOFILE=infinity` causes issues with various applications. This setting was removed by the upstream. See: containerd/containerd@3ca39ef.
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/3996 |
occ
added a commit
to occ/rook
that referenced
this pull request
May 28, 2024
Add a note to remove LimitNOFILE setting in containerd service configuration. This setting causes multiple issues such as slow ceph status commands (and failing healthchecks), various timeouts, and mons failing/timing out. This is fixed in the upstream containerd repository. NixOS hasn't incorporated the change. This note can be removed once NixOS/nixpkgs#313507 makes it to a stable release.
occ
added a commit
to occ/rook
that referenced
this pull request
May 28, 2024
Add a note to remove LimitNOFILE setting in containerd service configuration. This setting causes multiple issues such as slow `ceph status` commands (and failing healthchecks), various timeouts, and mons failing/timing out. Upstream containerd already removed the setting. NixOS hasn't incorporated the change. This note can be removed once NixOS/nixpkgs#313507 makes it to a stable release. Signed-off-by: Onur Cakmak <occ@occ.me>
6 tasks
occ
added a commit
to occ/rook
that referenced
this pull request
May 28, 2024
Add a note to remove LimitNOFILE setting in containerd service configuration. This setting causes multiple issues such as slow `ceph status` commands (and failing healthchecks), various timeouts, and mons failing/timing out. Upstream containerd already removed the setting. NixOS hasn't incorporated the change. This note can be removed once NixOS/nixpkgs#313507 makes it to a stable release. Signed-off-by: Onur Cakmak <occ@occ.me>
occ
added a commit
to occ/rook
that referenced
this pull request
May 28, 2024
Add a note to remove LimitNOFILE setting in containerd service configuration. This setting causes multiple issues such as slow `ceph status` commands (and failing healthchecks), various timeouts, and mons failing/timing out. Upstream containerd already removed the setting. NixOS hasn't incorporated the change. This note can be removed once NixOS/nixpkgs#313507 makes it to a stable release. Signed-off-by: Onur Cakmak <occ@occ.me>
mergify bot
pushed a commit
to rook/rook
that referenced
this pull request
May 28, 2024
Add a note to remove LimitNOFILE setting in containerd service configuration. This setting causes multiple issues such as slow `ceph status` commands (and failing healthchecks), various timeouts, and mons failing/timing out. Upstream containerd already removed the setting. NixOS hasn't incorporated the change. This note can be removed once NixOS/nixpkgs#313507 makes it to a stable release. Signed-off-by: Onur Cakmak <occ@occ.me> (cherry picked from commit d1e139c)
6 tasks
SuperSandro2000
approved these changes
Jun 2, 2024
SuperSandro2000
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Things done
Remove
LimitNOFILE=infinityfrom containerd service configuration.Having
LimitNOFILE=infinitycauses issues with various applications. This setting was removed by the upstream. See: containerd/containerd@3ca39ef.I saw this setting causing a problem in production. See my comment here.
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.