Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Filius - Computer Network Simulator. #318005

Closed
wants to merge 0 commits into from
Closed

Conversation

rcmlz
Copy link

@rcmlz rcmlz commented Jun 7, 2024

Description of changes

Adding new package Filius https://www.lernsoftware-filius.de

Filius is a Computer Network Simulator written in Java and distributed as .jar file.

With the software tool Filius, you can design computer networks yourself, simulate the exchange of messages in them and thus explore their structure and functionality experimentally. The target group are learners at secondary level in general education schools. Filius enables learning activities that are designed to support discovery-based learning in particular.

Things done

  • Built on platform(s)
    • [x ] x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@rcmlz
Copy link
Author

rcmlz commented Jun 25, 2024

@auroraanna - are you still working on PR? Maybe we can start with the simple binary .zip install wrapper version of this PR and then move on later to your approach? In any case, may I add you as maintainer?

@auroraanna
Copy link
Contributor

@rcmlz yes, you can add me as a maintainer

@auroraanna
Copy link
Contributor

the mime type file for filius projects and the .desktop should be added too

@rcmlz
Copy link
Author

rcmlz commented Jun 26, 2024

the mime type file for filius projects and the .desktop should be added too

I used the makeDesktopItem you used in your initial PR. What do you mean by "the .desktop should be added too"? What should I put in?

@rcmlz rcmlz force-pushed the filius branch 3 times, most recently from a890e35 to 7de0ec1 Compare June 26, 2024 20:16
@ofborg ofborg bot requested a review from auroraanna June 26, 2024 21:33
icon = "filius";
exec = "filius";
terminal = false;
mimeTypes = [ "application/filius-project" ];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the mimetype listed here but you're not installing the mimetype file (can be found at /src/deb/application-filius-project.xml in the gitlab repo e.g.)

@github-actions github-actions bot added 6.topic: python 6.topic: nixos 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: haskell 6.topic: qt/kde 8.has: documentation 8.has: changelog 8.has: module (update) 6.topic: emacs 6.topic: rust 6.topic: policy discussion 6.topic: vim 6.topic: ocaml 6.topic: xfce The Xfce Desktop Environment 6.topic: pantheon The Pantheon desktop environment 6.topic: TeX Issues regarding texlive and TeX in general 6.topic: testing Tooling for automated testing of packages and modules 6.topic: cinnamon 6.topic: module system About "NixOS" module system internals 6.topic: systemd 6.topic: vscode 6.topic: flakes The experimental Nix feature 6.topic: lib The Nixpkgs function library 6.topic: jupyter Interactive computing tooling: kernels, notebook, jupyterlab 6.topic: k3s 6.topic: dotnet Language: .NET labels Jul 10, 2024
@rcmlz rcmlz deleted the filius branch July 10, 2024 11:03
@rcmlz rcmlz restored the filius branch July 10, 2024 11:04
@NixOS NixOS locked and limited conversation to collaborators Jul 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants