-
-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dnsmap: init at 0.36-unstable-2024-08-20 #320346
Conversation
Eval is failing because of missing maintainer. You could |
Since you are a maintainer now, you need to rebase this PR. Also rebase to master, since it's been a while. |
e4d9b01
to
77bbf26
Compare
@superherointj sorry for the delay on my end, I missed these notifications. I think I addressed all your feedback in the latest force push. I wasn't sure if there was a better way to version dnsmap vs just Please let me know if there's any other follow-up needed on my end |
Please fix commit message:
|
pkgs/by-name/dn/dnsmap/package.nix
Outdated
]; | ||
|
||
meta = { | ||
description = "Scan for subdomains using bruteforcing techniques "; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
description = "Scan for subdomains using bruteforcing techniques "; | |
description = "Scan for subdomains using brute-force techniques"; |
- empty space at end
- https://en.wikipedia.org/wiki/Brute-force_attack
ping @heywoodlh |
@superherointj thanks for the ping, will address the feedback you brought up sometime this week |
@superherointj, sorry for the delay, I think I've addressed all your points on the latest force push. |
The multiple delay has been too long. I lose context of things.
No. See.
You did not even test building the package. The build is failing. I have already been very clear on what needs to be done. |
@superherointj sorry! I forgot to commit and push that piece. Very embarrassing. I added them to |
Description of changes
Added dnsmap
Related: #81418
(I didn't add myself as a maintainer because of all the other open commits I have in a pending state -- please let me know if I should add the maintainer commit to this PR as well)
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.