Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnsmap: init at 0.36-unstable-2024-08-20 #320346

Merged
merged 1 commit into from
Aug 21, 2024
Merged

Conversation

heywoodlh
Copy link
Contributor

Description of changes

Added dnsmap

Related: #81418

(I didn't add myself as a maintainer because of all the other open commits I have in a pending state -- please let me know if I should add the maintainer commit to this PR as well)

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@superherointj superherointj changed the title dnsmap init: unstable-2024-06-16 dnsmap: init 0.36-unstable-2024-06-16 Jun 18, 2024
@superherointj
Copy link
Contributor

Eval is failing because of missing maintainer.

You could cherry-pick the commit that adds yourself as maintainer. And use same cherry-pick for all your PRs, it won't duplicate it. And on rebasing it will merge fine.

@superherointj
Copy link
Contributor

superherointj commented Jul 11, 2024

Since you are a maintainer now, you need to rebase this PR. Also rebase to master, since it's been a while.

@heywoodlh
Copy link
Contributor Author

@superherointj sorry for the delay on my end, I missed these notifications. I think I addressed all your feedback in the latest force push.

I wasn't sure if there was a better way to version dnsmap vs just 0.36-unstable-$DATE -- because if you run dnsmap, you'll see the version is still 0.36 in the output -- but there have been commits to the repository since the 0.36 release. So I think my version naming clearly illustrates that the major version is 0.36 but there have been updates to it, therefore it's still "unstable".

Please let me know if there's any other follow-up needed on my end

@superherointj
Copy link
Contributor

Please fix commit message:

dnsmap: init at 0.36-unstable-2024-08-08

@superherointj superherointj changed the title dnsmap: init 0.36-unstable-2024-06-16 dnsmap: init at 0.36-unstable-2024-06-16 Aug 8, 2024
];

meta = {
description = "Scan for subdomains using bruteforcing techniques ";
Copy link
Contributor

@superherointj superherointj Aug 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
description = "Scan for subdomains using bruteforcing techniques ";
description = "Scan for subdomains using brute-force techniques";

@superherointj
Copy link
Contributor

ping @heywoodlh

@heywoodlh
Copy link
Contributor Author

@superherointj thanks for the ping, will address the feedback you brought up sometime this week

@heywoodlh
Copy link
Contributor Author

@superherointj, sorry for the delay, I think I've addressed all your points on the latest force push.

@heywoodlh heywoodlh changed the title dnsmap: init at 0.36-unstable-2024-06-16 dnsmap: init at 0.36-unstable-2024-08-20 Aug 21, 2024
@superherointj
Copy link
Contributor

superherointj commented Aug 21, 2024

@superherointj, sorry for the delay,

The multiple delay has been too long. I lose context of things.

I think I've addressed all your points on the latest force push.

No. See.

autoconf, automake should be in nativeBuildInputs.

You did not even test building the package. The build is failing.

I have already been very clear on what needs to be done.

@heywoodlh
Copy link
Contributor Author

heywoodlh commented Aug 21, 2024

@superherointj sorry! I forgot to commit and push that piece. Very embarrassing.

I added them to nativeBuildInputs and the build is working for me.

@superherointj superherointj merged commit 841a0c1 into NixOS:master Aug 21, 2024
24 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants