Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lomiri.lomiri-clock-app: init at 4.0.3 #323469

Merged
merged 3 commits into from
Jul 8, 2024

Conversation

OPNA2608
Copy link
Contributor

@OPNA2608 OPNA2608 commented Jun 29, 2024

Description of changes

Working towards #99090.

Lomiri Clock App. Self-explanatory. Tick Tock.
Bildschirmfoto_2024-06-29_23-36-09

Leftover issues:

  • I haven't been able to get any alarm sounds working, but I think the actual sound output might get dispatched to another service?
  • Crashes when dispatched from ayatana-indicator-datetime's clock link from within Lomiri. Down to a bug in qtsystems, will fix that in separate PR. libsForQt5.qtsystems: Fetch patch to fix crash on XOpenDisplay failure #323485
  • On launch, prints:
    - WARNING: alarm manager "eds" not installed, using "memory"
    
    Message is from lomiri-ui-toolkit, about qtorganiser-eds, which needs address-book-service… Or maybe evolution-data-server-lomiri, which extracts the relevant bits from the former… Or maybe this gets replaced at some point, from what I've caught on Telegram? Not sure, and don't think it's super critical for our non-phone usecase if this isn't working 100% right now.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@OPNA2608
Copy link
Contributor Author

OPNA2608 commented Jun 30, 2024

@ofborg build nixosTests.lomiri

@OPNA2608 OPNA2608 force-pushed the init/lomiri/lomiri-clock-app branch 4 times, most recently from de40757 to 290d271 Compare July 5, 2024 07:15
@OPNA2608 OPNA2608 force-pushed the init/lomiri/lomiri-clock-app branch from 290d271 to f7b9025 Compare July 8, 2024 09:21
@OPNA2608 OPNA2608 force-pushed the init/lomiri/lomiri-clock-app branch from f7b9025 to 2204726 Compare July 8, 2024 14:02
@SuperSandro2000 SuperSandro2000 merged commit e08b520 into NixOS:master Jul 8, 2024
27 of 31 checks passed
Copy link
Contributor

github-actions bot commented Jul 8, 2024

Backport failed for release-24.05, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release-24.05
git worktree add -d .worktree/backport-323469-to-release-24.05 origin/release-24.05
cd .worktree/backport-323469-to-release-24.05
git switch --create backport-323469-to-release-24.05
git cherry-pick -x 2bfead0040d8564d2e78a0084e12942c8529837a 3efabb335915d435908c9e01b872dbe17ea857b3 2204726a6d2d2ad16f1de3e17e0cbcd1ad70fb8d

@OPNA2608 OPNA2608 added backport release-24.05 Backport PR automatically and removed backport release-24.05 Backport PR automatically labels Jul 8, 2024
Copy link
Contributor

github-actions bot commented Jul 8, 2024

Successfully created backport PR for release-24.05:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants