-
-
Notifications
You must be signed in to change notification settings - Fork 13.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
aider-chat: init at 0.50.0 + python3Packages.pypager: init at 3.0.1 #323927
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution! Some feedback below; I avoided repeating any feedback, but most of these apply to all the files.
Thanks for the feedback! Should be fine now. |
Result of 4 packages marked as broken and skipped:
|
A related PR adds |
Based on taha-yassine's work (NixOS#323927) but porting a more recent version of the package. Features a bunch of changes such as using pyproject, replacing python3.pkgs with python311Packages (pinned due to treesitting not supported on python3.12). Enables testing, with a couple of deselected tests
Based on taha-yassine's work (NixOS#323927) but porting a more recent version of the package. Features a bunch of changes such as using pyproject, replacing python3.pkgs with python311Packages (pinned due to treesitting not supported on python3.12). Enables testing, with a couple of deselected tests Co-Authored-by: Taha Yassine <taha.yssne@gmail.com>
Based on taha-yassine's work (NixOS#323927) but porting a more recent version of the package. Features a bunch of changes such as using pyproject, replacing python3.pkgs with python311Packages (pinned due to treesitting not supported on python3.12). Enables testing, with a couple of deselected tests Co-Authored-by: taha-yassine <taha.yssne@gmail.com>
Hi @taha-yassine, I've ported I think it is worth checking out, as it adds a bunch of changes such as using pyproject, replacing Most importantly, I was able to enables testing, with only a couple of deselected tests. PS: welcome from a rennais! |
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/50-packaging-bound-aider/49867/18 |
@Sigmanificient, I do see Python 3.12 Linux wheels on the tree-sitter 0.12.3 PyPI downloads page – this is the tree-sitter version which Aider 0.47.1 requires. |
Based on taha-yassine's work (NixOS#323927) but porting a more recent version of the package. Features a bunch of changes such as using pyproject, replacing python3.pkgs with python311Packages (pinned due to treesitting not supported on python3.12). Enables testing, with a couple of deselected tests Co-Authored-by: taha-yassine <taha.yssne@gmail.com>
This comment was marked as resolved.
This comment was marked as resolved.
My grep-ast package was just merged earlier today. I'm also toiling to get aider build. By now it's at 0.47.1 and requires lox, which my PR for is still pending. |
@Sigmanificient thanks a lot for your work, it was very helpful :) @greg-hellings lox is a dev dependency and only needed for running a benchmark upstream, so it isn't needed here imo PR is ready again for review now that @Sigmanificient @greg-hellings do you want to be added as maintainers as well? |
I would prefer to update to the very latest, I'll actively follow the development of this thread tomorrow and merge it if CI is green. |
In that case should I add |
It can be part of this PR as long as the commit log message is properly formatted ( |
|
Added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added 2 minor comments.
Make to pass only the new files through nixfmt-rfc-style
, ignore if it is already done.
|
Well done @taha-yassine - this was a lot more work than a new package usually requires. Great job sticking around to polish it / deal with all the requests. ❤️ |
I was merely the one who started the PR. I wouldn't have made it this far without the help of everyone that was involved. Thanks everyone! 😊 |
With thanks to: - NixOS/nixpkgs#323927 - paul-gauthier/aider#544
Description of changes
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.