Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[24.05] nixVersions.git: Fix version #324408

Merged

Conversation

Artturin
Copy link
Member

@Artturin Artturin commented Jul 3, 2024

(cherry picked from commit 5660f47)

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@roberth
Copy link
Member

roberth commented Jul 4, 2024

@emilazy
Copy link
Member

emilazy commented Jul 10, 2024

Thanks for this! Could you incorporate #326172 for the Darwin users?

@Artturin
Copy link
Member Author

Thanks for this! Could you incorporate #326172 for the Darwin users?

Done

@infinisil
Copy link
Member

For the formatting failure, see #326628

@Artturin Artturin merged commit 62dd610 into NixOS:release-24.05 Jul 16, 2024
22 of 24 checks passed
@Artturin Artturin deleted the backport-323140-to-release-24.05 branch July 16, 2024 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants