cc-wrapper: add support for pacret hardening flag on aarch64
#324429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
|
I built up to |
|
@ofborg eval |
emilazy
reviewed
Jul 28, 2024
github-actions
bot
added
the
6.topic: llvm/clang
|
Will merge after rebase. |
emilazy
approved these changes
Jul 28, 2024
|
Thanks for all your work on package hardening. Hopefully we can flip more of this stuff on by default in the future. |
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Rather than trying to shovel all these features under a single flag as in #320597, I'm now strongly leaning in the direction of exposing them separately (more on my reasoning @ https://discourse.nixos.org/t/future-design-of-hardening-flags/38826/6?u=ris)
One thing that stood out during the testing of #320597 was how few problems aarch64's
pac-retfeature appeared to cause compared to x86's shadow-stacks. So this leading me to fast-tracking support for it.The gotcha, again, is that I don't have access to one of these processors, so I'm going to need help testing this. Owners of ARM v8.3+ systems doing a bootstrap build of e.g.
pkgsExtraHardening.helloon this branch would really be helping us out here. Example systems implementing ARM v8.3+ include AWS Graviton3 or Apple M1+ systems (running linux). The common Ampere Altra systems (including the Nix community builder and Hetzner) do not implement ARM v8.3.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.