-
-
Notifications
You must be signed in to change notification settings - Fork 13.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gpu-screen-recorder{,-gtk}: Update to unstable-2024-07-05 (+ systemd unit and capabilities) #324585
Conversation
https://git.dec05eba.com/gpu-screen-recorder-gtk/tree/com.dec05eba.gpu_screen_recorder.appdata.xml there is a changelog for the larger changes (this is the changelog used by the flatpak) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can confirm that root wrappers work as expected, thanks!
0336389
to
d507aea
Compare
Changes since last push:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Looks great. Thanks for making this! I've been meaning to make something for this but never got around to it. Could this work well with the unstable updater? gpu-screen-recorder in the past has been lacking updates in nixpkgs. |
It doesn't appear to be compatible without any changes, and given that we ideally want to keep using snapshot tarballs and since there are no usable tags anyways (which appears to account for roughly 50% of unstable updater code), it's most likely easier to just script something separate. |
Co-authored-by: oddlama <oddlama@oddlama.org> Co-authored-by: ash <ash@sorrel.sh>
d507aea
to
c1c9d38
Compare
Description of changes
Non-NixOS related changes can be found here. Relevant changes start from 2024-05-21 for
gpu-screen-recorder
and from 3.7.6 forgpu-screen-recorder-gtk
.NixOS-specific changes include the following:
programs.gpu-screen-recorder
to host an option for generatingsetcap
wrappersgpu-screen-recorder-gtk
to using tarballs instead of Git (as the developer explicitly asked for that in gpu-screen-recorder: 1.0.0 -> unstable-2023.11.18 #268443)Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.