Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gpu-screen-recorder{,-gtk}: Update to unstable-2024-07-05 (+ systemd unit and capabilities) #324585

Merged
merged 5 commits into from
Jul 13, 2024

Conversation

timschumi
Copy link
Member

@timschumi timschumi commented Jul 4, 2024

Description of changes

Non-NixOS related changes can be found here. Relevant changes start from 2024-05-21 for gpu-screen-recorder and from 3.7.6 for gpu-screen-recorder-gtk.

NixOS-specific changes include the following:

  • Switch from the script-based build system to meson
  • Install the upstream-provided systemd user service file
  • Create programs.gpu-screen-recorder to host an option for generating setcap wrappers
  • Return gpu-screen-recorder-gtk to using tarballs instead of Git (as the developer explicitly asked for that in gpu-screen-recorder: 1.0.0 -> unstable-2023.11.18 #268443)

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@dec05eba
Copy link

dec05eba commented Jul 4, 2024

https://git.dec05eba.com/gpu-screen-recorder-gtk/tree/com.dec05eba.gpu_screen_recorder.appdata.xml there is a changelog for the larger changes (this is the changelog used by the flatpak)

@timschumi timschumi changed the title gpu-screen-recorder: unstable-2024-05-21 -> unstable-2024-07-04 gpu-screen-recorder: unstable-2024-05-21 -> unstable-2024-07-04 (+ systemd unit and capabilities) Jul 4, 2024
Copy link
Contributor

@oddlama oddlama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can confirm that root wrappers work as expected, thanks!

@timschumi timschumi force-pushed the gsr-2024-07-04 branch 2 times, most recently from 0336389 to d507aea Compare July 5, 2024 21:30
@timschumi timschumi changed the title gpu-screen-recorder: unstable-2024-05-21 -> unstable-2024-07-04 (+ systemd unit and capabilities) gpu-screen-recorder{,-gtk}: Update to unstable-2024-07-05 (+ systemd unit and capabilities) Jul 5, 2024
@timschumi
Copy link
Member Author

timschumi commented Jul 5, 2024

Changes since last push:

  • Rebased onto current master to resolve gpu-screen-recorder-gtk-related conflicts (diff from last time without rebase noise available here).
  • Update gpu-screen-recorder-gtk in lockstep. This includes returning to an un-"tagged" revision to match gpu-screen-recorder.
  • Switch gpu-screen-recorder-gtk to the Meson build system (direct result of previous entry).
  • Return to tarball downloading for gpu-screen-recorder-gtk as originally requested by the maintainer in gpu-screen-recorder: 1.0.0 -> unstable-2023.11.18 #268443.
  • Uprev from 2024-07-04 to 2024-07-05.

Copy link
Contributor

@oddlama oddlama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@keenanweaver
Copy link
Member

keenanweaver commented Jul 10, 2024

Looks great. Thanks for making this! I've been meaning to make something for this but never got around to it.

Could this work well with the unstable updater? gpu-screen-recorder in the past has been lacking updates in nixpkgs.

@timschumi
Copy link
Member Author

Could this work well with the unstable updater? gpu-screen-recorder in the past has been lacking updates in nixpkgs.

It doesn't appear to be compatible without any changes, and given that we ideally want to keep using snapshot tarballs and since there are no usable tags anyways (which appears to account for roughly 50% of unstable updater code), it's most likely easier to just script something separate.

@symphorien symphorien merged commit 98f7683 into NixOS:master Jul 13, 2024
26 of 28 checks passed
@timschumi timschumi deleted the gsr-2024-07-04 branch July 13, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants