fdroidserver: reformat, refactor, unstable-2023-10-23 -> 2.3a1 #325093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Result of 2 packages built:
|
|
Result of 2 packages built:
|
jugendhacker
approved these changes
Jul 6, 2024
There was a problem hiding this comment.
Looks good to be, from what I can tell everything works as expected, but we should probably wait for @linsui to review it too
linsui
approved these changes
Jul 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Fixes fdroidserver by upgrading it to a new version that removes the distutils dependency (broken in Python 3.12.) Also performs RFC formatting and some other refactors to hopefully improve the quality of the derivation.
(Note: The reason why 2.3a1 is chosen is because the latest stable release does not contain the distutils fix.)
Note: I do not have the knowledge to properly exercise this, it seems to work, I'm not sure exactly what to test. Please let me know if there's anything in particular I should be running through.
Fixes #325076.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.